[Refactor] Expose meta-schedule related packed func in a header and call it directly #10470
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
masahi
changed the title
masahi
requested review from
MarisaKirisame,
ZihengJiang,
anijain2305,
comaniac,
icemelon,
jroesch,
junrushao,
jwfromm,
kparzysz-quic,
mbrookhart,
slyubomirsky,
tqchen,
vinx13,
wweic,
yzhliu and
zhiics
as code owners
masahi
changed the title
Member
Author
|
@junrushao1994 good to go? |
junrushao
approved these changes
Mar 4, 2022
Member
|
Thanks @masahi! It’s merged! |
ziqiangxu8457
pushed a commit
to ziqiangxu8457/tvm
that referenced
this pull request
Mar 6, 2022
…all it directly (apache#10470) * [MetaSchedule] Expose CreatePrimFuncFromOutputs in a header and call it directly * add include guard * exposed ContextQueryInsideWithScope too * oops * add tir namespace for clarity * address comment
pfk-beta
pushed a commit
to pfk-beta/tvm
that referenced
this pull request
Apr 11, 2022
…all it directly (apache#10470) * [MetaSchedule] Expose CreatePrimFuncFromOutputs in a header and call it directly * add include guard * exposed ContextQueryInsideWithScope too * oops * add tir namespace for clarity * address comment
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This not only improves code hygiene, it also makes it easier to navigate to the function definition inside an editor. Please follow this style for future code.
@junrushao1994 @zxybazh @Hzfengsy