[CI] [1/2] Update the Python version of pyxir #10406
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ekalda
requested review from
areusch,
comaniac,
jroesch,
junrushao,
leandron and
tqchen
as code owners
Contributor
Author
Contributor
Author
leandron
approved these changes
Feb 28, 2022
Currently the CMake file for pyxir is looking for things in Python3.6, so it needs to be upgraded to use 3.7 now that we have moved to use 3.7. Otherwise the build fails when the docker images are updated since the 3.6 can't find the pyxir packages which have moved to 3.7. Additionally, there seems to be a problem with the newer version of setuptools installing the pyxir libraries, so reverting these versions to the previous versions as a workaraound. Note that this has to be done in two patches for the changes to go through the current CI, this patch downgrades the pip and setuptools versions.
ekalda
force-pushed
the
pyxir_python_version_fix
branch
from
94681ca to
f5f74c4
Compare
ekalda
changed the title
driazati
approved these changes
Feb 28, 2022
Member
driazati
left a comment
driazati
left a comment
There was a problem hiding this comment.
Thanks for the fix! This looks good pending a successful docker image build after merging
Contributor
pfk-beta
pushed a commit
to pfk-beta/tvm
that referenced
this pull request
Apr 11, 2022
Currently the CMake file for pyxir is looking for things in Python3.6, so it needs to be upgraded to use 3.7 now that we have moved to use 3.7. Otherwise the build fails when the docker images are updated since the 3.6 can't find the pyxir packages which have moved to 3.7. Additionally, there seems to be a problem with the newer version of setuptools installing the pyxir libraries, so reverting these versions to the previous versions as a workaraound. Note that this has to be done in two patches for the changes to go through the current CI, this patch downgrades the pip and setuptools versions.
|
An error occurred when I build demo_android: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently the CMake file for pyxir is looking for things in Python3.6,
so it needs to be upgraded to use 3.7 now that we have moved to use 3.7.
Otherwise the build fails since the 3.6 can't find the pyxir packages
which have moved to 3.7.
Additionally, there seems to be a problem with the newer version of
setuptools installing the pyxir libraries, so reverting these versions
to the previous versions as a workaround.
Note that this has to be done in two patches for the changes to go
through the current CI, this patch downgrades the pip and setuptools
versions.