-
Notifications
You must be signed in to change notification settings - Fork 3.7k
[Runtime] Improved log information with function signature #10326
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
@cyx-6 Would you mind if you could demonstrate what the new error messages look like? |
|
@junrushao1994 Sure. Here is an example for new error message:
If we wrongly call function |
|
Thanks! Would it be clearer to also show the index like below? Thanks a lot! |
|
The code has been updated. It looks much clearer now. |
junrushao
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the PR! LGTM
This PR introduces a function signature printer in the
TypedPackedFuncpart, so that the log information indetail::unpack_callwill be more complete. This PR allows users to obatin the original function signature when thedetail::unpack_callfails.cc @areusch