Generate correct output tensor names in C Interface API #10191
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
grant-arm
requested review from
Huyuwei,
MarisaKirisame,
ZihengJiang,
anijain2305,
areusch,
comaniac,
icemelon,
jroesch,
junrushao,
jwfromm,
kazum,
kparzysz-quic,
liangfu,
manupak,
masahi,
mbrookhart,
merrymercy,
siju-samuel,
slyubomirsky,
srkreddy1238,
tmoreau89,
tqchen,
vinx13,
wweic,
yzhliu and
zhiics
as code owners
Contributor
Author
grant-arm
force-pushed
the
output_tensor_names
branch
from
df746a3 to
9c602ea
Compare
Contributor
Author
|
@manupa-arm @Mousius @leandron @areusch would you mind taking a look at this now that the CI is green. |
Mousius
requested changes
Feb 16, 2022
Member
|
Overall looks ok to me @grant-arm , would just be good to use the name transformation functions if we can 😸 |
Change-Id: I90d86aef7d8b93fb937391a87f79ae9362207058
* Update output tensor name in Zephyr AOT test Change-Id: I90d983d0ccf216f923e2cd430581c0bad7afdf7a
* Update FreeRTOS demo * Update Zephyr RTOS demo with CMSIS-NN Change-Id: If1d255bc407503c203d66d1f3e04139c9cbed016
* Use sanitize_name() function on output tensor names Change-Id: I29452d24e13b6ed8b629241b9aa0dc090b42838e
grant-arm
force-pushed
the
output_tensor_names
branch
from
ff487c7 to
f77a659
Compare
Mousius
approved these changes
Feb 21, 2022
Member
|
Fantastic improvement @grant-arm! |
pfk-beta
pushed a commit
to pfk-beta/tvm
that referenced
this pull request
Apr 11, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently for the C Interface API, output tensor names default to "output", "output0", "output1" etc.
This is in contrast to the input tensor names that are derived from the model.
This PR updates the code to generate output tensor names derived from the model and updates unit tests accordingly.