Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CLEANUP] Clean up existing structural tests when structural testing infrastructure is created #9096

Closed
1 task
denise-k opened this issue Sep 23, 2021 · 1 comment

Comments

@denise-k
Copy link
Collaborator

denise-k commented Sep 23, 2021

Recently, there have been some discussions around creating infrastructure for structural tests, which test for the structure of the generated code rather than correctness of the output. This is currently on the backlog. Once the infrastructure is in place, there are places where structural tests exist in the code already which should be refactored to be more readable/cleaner.

Here's an initial list (to be edited over time):

@areusch
Copy link
Contributor

areusch commented Sep 27, 2021

In particular it would be great to create test-utils which allow someone to traverse TIR and find nodes e.g. similar to XPath so that it's easy to assert that a pass adds/removes various attrs from all instances of a particular node type.

@areusch areusch added the needs-triage PRs or issues that need to be investigated by maintainers to find the right assignees to address it label Oct 19, 2022
@hpanda-naut hpanda-naut added dev:test-infra and removed needs-triage PRs or issues that need to be investigated by maintainers to find the right assignees to address it labels Nov 28, 2022
@tqchen tqchen closed this as completed Sep 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants