Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[RELAY] Conditions in quantize.optimize are broken due to issue with tvm.Array #3273

Closed
vinx13 opened this issue Jun 1, 2019 · 5 comments
Closed

[RELAY] Conditions in quantize.optimize are broken due to issue with tvm.Array #3273

vinx13 opened this issue Jun 1, 2019 · 5 comments
Labels
type: bug

Comments

@vinx13
Copy link
Member

vinx13 commented Jun 1, 2019

This bug is introduced in #3234.
This condition https://github.com/dmlc/tvm/blob/f6acf2e5f51f9ac48f8d13e095805b7fe3f74bcf/python/tvm/relay/quantize/quantize.py#L324 is always False because cfg.required_pass is tvm.container.Array

cc @zhiics
@zhiics
Copy link
Member

zhiics commented Jun 1, 2019

Thanks for pointing out. I will fix this later by moving the whole function to the pass manager after #3251 is merged.

@tqchen
Copy link
Member

tqchen commented Jun 3, 2019

ping @zhiics @vinx13 let us fix this asap

@zhiics
Copy link
Member

zhiics commented Jun 3, 2019

Sorry, I am traveling today. I will fix it tomorrow.

@tqchen
Copy link
Member

tqchen commented Jun 3, 2019

#3283

@zhiics zhiics mentioned this issue Jun 4, 2019
Merged
@vinx13
Copy link
Member Author

vinx13 commented Jun 5, 2019

solved by #3283

@vinx13 vinx13 closed this as completed Jun 5, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
type: bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@tqchen @zhiics @vinx13