Skip to content

Commit df420b0

Browse files
committed
[REFACTOR][FFI] Phase out old VisitAttrs mechanism
This PR phases out the old VisitAttrs mechanism as we fully transition to use the new reflection mechanism for attribute get and object creation.
1 parent 17113f8 commit df420b0

Some content is hidden

Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.

52 files changed

+270
-1445
lines changed

ffi/include/tvm/ffi/object.h

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -214,7 +214,6 @@ class Object {
214214
static constexpr int32_t _type_depth = 0;
215215
// extra fields used by plug-ins for attribute visiting
216216
// and structural information
217-
static constexpr const bool _type_has_method_visit_attrs = true;
218217
static constexpr const bool _type_has_method_sequal_reduce = false;
219218
static constexpr const bool _type_has_method_shash_reduce = false;
220219
// The following functions are provided by macro

include/tvm/arith/int_solver.h

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -83,7 +83,6 @@ class IntGroupBoundsNode : public Object {
8383
hash_reduce(upper);
8484
}
8585

86-
static constexpr const bool _type_has_method_visit_attrs = false;
8786
static constexpr const bool _type_has_method_sequal_reduce = true;
8887
static constexpr const char* _type_key = "arith.IntGroupBounds";
8988
TVM_DECLARE_FINAL_OBJECT_INFO(IntGroupBoundsNode, Object);
@@ -174,7 +173,6 @@ class IntConstraintsNode : public Object {
174173
hash_reduce(relations);
175174
}
176175

177-
static constexpr const bool _type_has_method_visit_attrs = false;
178176
static constexpr const bool _type_has_method_sequal_reduce = true;
179177
static constexpr const char* _type_key = "arith.IntConstraints";
180178
TVM_DECLARE_FINAL_OBJECT_INFO(IntConstraintsNode, Object);
@@ -240,7 +238,6 @@ class IntConstraintsTransformNode : public Object {
240238
hash_reduce(dst_to_src);
241239
}
242240

243-
static constexpr const bool _type_has_method_visit_attrs = false;
244241
static constexpr const bool _type_has_method_sequal_reduce = true;
245242
static constexpr const char* _type_key = "arith.IntConstraintsTransform";
246243
TVM_DECLARE_FINAL_OBJECT_INFO(IntConstraintsTransformNode, Object);

0 commit comments

Comments
 (0)