Skip to content

Commit a611b3c

Browse files
committed
Merge branch 'hexagon_launcher_ergonomics' of github.com:Lunderberg/tvm into hexagon_launcher_ergonomics
2 parents f168f9a + cca8d47 commit a611b3c

File tree

1 file changed

+7
-12
lines changed

1 file changed

+7
-12
lines changed

tests/python/contrib/test_hexagon/conftest.py

Lines changed: 7 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -149,15 +149,6 @@ def tvm_tracker_port(_tracker_info) -> int:
149149
return port
150150

151151

152-
# @pytest.fixture(scope="session")
153-
# def tvm_tracker(tvm_tracker_port):
154-
# tracker = tvm.rpc.tracker.Tracker("127.0.0.1", tvm_tracker_port)
155-
# try:
156-
# yield tracker
157-
# finally:
158-
# tracker.terminate()
159-
160-
161152
@tvm.testing.fixture
162153
def rpc_server_port() -> int:
163154
return get_free_port()
@@ -169,12 +160,16 @@ def adb_server_socket() -> str:
169160

170161

171162
@tvm.testing.fixture
172-
def hexagon_launcher(
173-
android_serial_number, tvm_tracker_host, tvm_tracker_port, rpc_server_port, adb_server_socket
174-
):
163+
def hexagon_launcher(request, android_serial_number, rpc_server_port, adb_server_socket):
175164
if android_serial_number is None:
176165
yield None
177166
else:
167+
# Requesting these fixtures sets up a local tracker, if one
168+
# hasn't been provided to us. Delaying the evaluation of
169+
# these fixtures avoids starting a tracker unless necessary.
170+
tvm_tracker_host = request.getfixturevalue("tvm_tracker_host")
171+
tvm_tracker_port = request.getfixturevalue("tvm_tracker_port")
172+
178173
rpc_info = {
179174
"rpc_tracker_host": tvm_tracker_host,
180175
"rpc_tracker_port": tvm_tracker_port,

0 commit comments

Comments
 (0)