[logging] LOG(FATAL) calls [[noreturn]] functions

Ensure that `LOG(FATAL)` always resolves to calling
`[[noreturn]]` code.  This has two benefits:

- Helps developers more quickly understand the intended/required
  behavior for `LOG(FATAL)` calls.

- May eliminate spurious compiler warnings based on control-flow
  analysis.  E.g. gcc's / clang's `-Wno-return` warnings.

Author: Christian Convey

apps/android_camera/app/src/main/jni/tvm_runtime.h

@@ -74,7 +74,7 @@ namespace tvm {
 namespace runtime {
 namespace detail {
 // Override logging mechanism
-void LogFatalImpl(const std::string& file, int lineno, const std::string& message) {
+[[noreturn]] void LogFatalImpl(const std::string& file, int lineno, const std::string& message) {
   std::string m = file + ":" + std::to_string(lineno) + ": " + message;
   __android_log_write(ANDROID_LOG_DEBUG, "TVM_RUNTIME", m.c_str());
   throw InternalError(file, lineno, message);

apps/android_rpc/app/src/main/jni/tvm_runtime.h

@@ -92,7 +92,7 @@ namespace tvm {
 namespace runtime {
 namespace detail {
 // Override logging mechanism
-void LogFatalImpl(const std::string& file, int lineno, const std::string& message) {
+[[noreturn]] void LogFatalImpl(const std::string& file, int lineno, const std::string& message) {
   std::string m = file + ":" + std::to_string(lineno) + ": " + message;
   __android_log_write(ANDROID_LOG_DEBUG, "TVM_RUNTIME", m.c_str());
   throw InternalError(file, lineno, message);

apps/ios_rpc/tvmrpc/TVMRuntime.mm

@@ -41,7 +41,7 @@
 namespace detail {
 
 // Override logging mechanism
-void LogFatalImpl(const std::string& file, int lineno, const std::string& message) {
+[[noreturn]] void LogFatalImpl(const std::string& file, int lineno, const std::string& message) {
   throw tvm::runtime::InternalError(file, lineno, message);
 }
 

include/tvm/runtime/logging.h

@@ -286,7 +286,8 @@ namespace detail {
  *
  * \sa TVM_LOG_CUSTOMIZE
  */
-TVM_DLL void LogFatalImpl(const std::string& file, int lineno, const std::string& message);
+[[noreturn]] TVM_DLL void LogFatalImpl(const std::string& file, int lineno,
+                                       const std::string& message);
 
 /*!
  * \brief Custom implementations of LogMessage.
@@ -306,7 +307,7 @@ class LogFatal {
 #pragma disagnostic push
 #pragma warning(disable : 4722)
 #endif
-  ~LogFatal() TVM_THROW_EXCEPTION { LogFatalImpl(file_, lineno_, stream_.str()); }
+  [[noreturn]] ~LogFatal() TVM_THROW_EXCEPTION { LogFatalImpl(file_, lineno_, stream_.str()); }
 #ifdef _MSC_VER
 #pragma disagnostic pop
 #endif

src/runtime/hexagon/hexagon_common.cc

@@ -84,7 +84,7 @@ void HexagonLog(const std::string& file, int lineno, const std::string& message)
 }  // namespace
 
 namespace detail {
-void LogFatalImpl(const std::string& file, int lineno, const std::string& message) {
+[[noreturn]] void LogFatalImpl(const std::string& file, int lineno, const std::string& message) {
   HexagonLog(file, lineno, message);
   throw InternalError(file, lineno, message);
 }

web/emcc/wasm_runtime.cc

@@ -68,7 +68,7 @@ namespace tvm {
 namespace runtime {
 namespace detail {
 // Override logging mechanism
-void LogFatalImpl(const std::string& file, int lineno, const std::string& message) {
+[[noreturn]] void LogFatalImpl(const std::string& file, int lineno, const std::string& message) {
   std::cerr << "[FATAL] " << file << ":" << lineno << ": " << message << std::endl;
   abort();
 }