Commit 5345b05
committed
[Fix][TIR] LowerThreadAllreduce warp reduction mask
The warp reduction implemented by "shuffle down" primitive takes a
mask denoting the active threads within the warp that participate
in this shuffle.
Previously we compute the mask, while in practice we find that it
results in "CUDA illegal instruction" error on NVIDIA H100 GPU when
the mask is set, and the issue is gone if we do not update the mask.
Therefore, this PR updates the allreduce lowering to remove the mask
update.
Confirmed the correctness on the following devices:
* NVIDIA H100,
* NVIDIA RTX 4090,
* AMD Radeon 7900 XTX,
* Apple M2 Ultra.1 parent 99defd2 commit 5345b05
1 file changed
+0
-7
lines changed| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
294 | 294 | | |
295 | 295 | | |
296 | 296 | | |
297 | | - | |
298 | | - | |
299 | | - | |
300 | | - | |
301 | 297 | | |
302 | 298 | | |
303 | 299 | | |
| |||
352 | 348 | | |
353 | 349 | | |
354 | 350 | | |
355 | | - | |
356 | | - | |
357 | | - | |
358 | 351 | | |
359 | 352 | | |
360 | 353 | | |
| |||
0 commit comments