Skip to content

Commit 85d8162

Browse files
committed
Revert "THRIFT-4951: Remove senum from tests"
This reverts commit df8ef4b. The contributor confuses "deprecated" with "unsupported". Unless the feature as a whole is also removed, so essentially nothing is left to be tested. Regardless whether a particular feature is deprecated or not, removing a working test for it is NOT helpful. The only "achievement" of such efforts would be that the test coverage goes down, which is clearly not in our intention and only opens room for bugs and issues.
1 parent 224b43e commit 85d8162

File tree

2 files changed

+15
-0
lines changed

2 files changed

+15
-0
lines changed

test/AnnotationTest.thrift

+8
Original file line numberDiff line numberDiff line change
@@ -49,6 +49,14 @@ enum weekdays {
4949
SATURDAY ( weekend = "yes" )
5050
} (foo.bar="baz")
5151

52+
/* Note that annotations on senum values are not supported. */
53+
senum seasons {
54+
"Spring",
55+
"Summer",
56+
"Fall",
57+
"Winter"
58+
} ( foo = "bar" )
59+
5260
struct ostr_default {
5361
1: i32 bar;
5462
}

test/SmallTest.thrift

+7
Original file line numberDiff line numberDiff line change
@@ -24,6 +24,12 @@ struct Goodbyez {
2424
1: i32 val = 325;
2525
}
2626

27+
senum Thinger {
28+
"ASDFKJ",
29+
"r32)*F#@",
30+
"ASDFLJASDF"
31+
}
32+
2733
struct BoolPasser {
2834
1: bool value = 1
2935
}
@@ -47,6 +53,7 @@ exception Goodbye {
4753
}
4854

4955
service SmallService {
56+
Thinger testThinger(1:Thinger bootz),
5057
Hello testMe(1:i32 hello=64, 2: Hello wonk) throws (1: Goodbye g),
5158
void testVoid() throws (1: Goodbye g),
5259
i32 testI32(1:i32 boo)

0 commit comments

Comments
 (0)