Skip to content

Commit

Permalink
Revert "THRIFT-4951: Remove senum from tests"
Browse files Browse the repository at this point in the history
This reverts commit df8ef4b.

The contributor confuses "deprecated" with "unsupported". Unless the feature as a whole is also removed, so essentially nothing is left to be tested. Regardless whether a particular feature is deprecated or not, removing a working test for it is NOT helpful. The only "achievement" of such efforts would be that the test coverage goes down, which is clearly not in our intention and only opens room for bugs and issues.
  • Loading branch information
Jens-G committed Oct 9, 2019
1 parent 224b43e commit 85d8162
Show file tree
Hide file tree
Showing 2 changed files with 15 additions and 0 deletions.
8 changes: 8 additions & 0 deletions test/AnnotationTest.thrift
Original file line number Diff line number Diff line change
Expand Up @@ -49,6 +49,14 @@ enum weekdays {
SATURDAY ( weekend = "yes" )
} (foo.bar="baz")

/* Note that annotations on senum values are not supported. */
senum seasons {
"Spring",
"Summer",
"Fall",
"Winter"
} ( foo = "bar" )

struct ostr_default {
1: i32 bar;
}
Expand Down
7 changes: 7 additions & 0 deletions test/SmallTest.thrift
Original file line number Diff line number Diff line change
Expand Up @@ -24,6 +24,12 @@ struct Goodbyez {
1: i32 val = 325;
}

senum Thinger {
"ASDFKJ",
"r32)*F#@",
"ASDFLJASDF"
}

struct BoolPasser {
1: bool value = 1
}
Expand All @@ -47,6 +53,7 @@ exception Goodbye {
}

service SmallService {
Thinger testThinger(1:Thinger bootz),
Hello testMe(1:i32 hello=64, 2: Hello wonk) throws (1: Goodbye g),
void testVoid() throws (1: Goodbye g),
i32 testI32(1:i32 boo)
Expand Down

0 comments on commit 85d8162

Please sign in to comment.