From 361f44ecbde8108f56400ff98cea0b828f26e4da Mon Sep 17 00:00:00 2001
From: Maxime Beauchemin <maximebeauchemin@gmail.com>
Date: Tue, 10 May 2016 13:13:25 -0700
Subject: [PATCH] Don't limit parallel coordinates table size

Before we limited the table size to 10 rows, now there's no limit and it
will overflow properly with a scrollbar.
---
 caravel/assets/stylesheets/parallel_coordinates.css   |  7 +++++++
 caravel/assets/visualizations/parallel_coordinates.js | 11 ++++++-----
 2 files changed, 13 insertions(+), 5 deletions(-)
 create mode 100644 caravel/assets/stylesheets/parallel_coordinates.css

diff --git a/caravel/assets/stylesheets/parallel_coordinates.css b/caravel/assets/stylesheets/parallel_coordinates.css
new file mode 100644
index 000000000000..3135e2cc687d
--- /dev/null
+++ b/caravel/assets/stylesheets/parallel_coordinates.css
@@ -0,0 +1,7 @@
+.para div.grid {
+    overflow: auto;
+}
+
+.para div.row:hover {
+    background-color: #CCC;
+}
diff --git a/caravel/assets/visualizations/parallel_coordinates.js b/caravel/assets/visualizations/parallel_coordinates.js
index c22a775c9f90..b02f1eba7605 100644
--- a/caravel/assets/visualizations/parallel_coordinates.js
+++ b/caravel/assets/visualizations/parallel_coordinates.js
@@ -6,6 +6,7 @@ d3.divgrid = require('../vendor/parallel_coordinates/divgrid.js');
 
 // CSS
 require('../vendor/parallel_coordinates/d3.parcoords.css');
+require('../stylesheets/parallel_coordinates.css');
 
 function parallelCoordVis(slice) {
 
@@ -66,10 +67,10 @@ function parallelCoordVis(slice) {
           // create data table, row hover highlighting
           var grid = d3.divgrid();
           container.append("div")
-            .datum(data.slice(0, 10))
-            .attr('id', "grid")
+            .style('height', eff_height + 'px')
+            .datum(data)
             .call(grid)
-            .classed("parcoords", true)
+            .classed("parcoords grid", true)
             .selectAll(".row")
             .on({
               mouseover: function (d) {
@@ -79,8 +80,8 @@ function parallelCoordVis(slice) {
             });
           // update data table on brush event
           parcoords.on("brush", function (d) {
-            d3.select("#grid")
-              .datum(d.slice(0, 10))
+            d3.select(".grid")
+              .datum(d)
               .call(grid)
               .selectAll(".row")
               .on({