diff --git a/caravel/models.py b/caravel/models.py index 49f5584d173c..785dfdb06762 100644 --- a/caravel/models.py +++ b/caravel/models.py @@ -31,7 +31,7 @@ from six import string_types from sqlalchemy import ( Column, Integer, String, ForeignKey, Text, Boolean, DateTime, Date, - Table, create_engine, MetaData, desc, select, and_, func) + Table, create_engine, MetaData, select, and_, func) from sqlalchemy.engine import reflection from sqlalchemy.ext.declarative import declared_attr from sqlalchemy.orm import relationship @@ -583,13 +583,6 @@ def query( # sqla m.sqla_col for m in self.metrics if m.metric_name in metrics] - if metrics: - main_metric_expr = [ - m.sqla_col for m in self.metrics - if m.metric_name == metrics[0]][0] - else: - main_metric_expr = literal_column("COUNT(*)").label("ccount") - select_exprs = [] groupby_exprs = [] @@ -670,8 +663,6 @@ def query( # sqla else: qry = qry.where(and_(*where_clause_and)) qry = qry.having(and_(*having_clause_and)) - if groupby: - qry = qry.order_by(desc(main_metric_expr)) qry = qry.limit(row_limit) if timeseries_limit and groupby: @@ -679,7 +670,6 @@ def query( # sqla subq = subq.select_from(tbl) subq = subq.where(and_(*(where_clause_and + inner_time_filter))) subq = subq.group_by(*inner_groupby_exprs) - subq = subq.order_by(desc(main_metric_expr)) subq = subq.limit(timeseries_limit) on_clause = [] for i, gb in enumerate(groupby):