From e3b7370b9aae0ede399ee69a3626eab7cb49b932 Mon Sep 17 00:00:00 2001 From: Mehmet Salih Yavuz Date: Tue, 23 Sep 2025 10:11:04 +0300 Subject: [PATCH 1/2] fix(ConditionalFormattingControl): icon color in dark mode --- .../ConditionalFormattingControl.tsx | 1 - 1 file changed, 1 deletion(-) diff --git a/superset-frontend/src/explore/components/controls/ConditionalFormattingControl/ConditionalFormattingControl.tsx b/superset-frontend/src/explore/components/controls/ConditionalFormattingControl/ConditionalFormattingControl.tsx index 6724b269f8e5..e15346156974 100644 --- a/superset-frontend/src/explore/components/controls/ConditionalFormattingControl/ConditionalFormattingControl.tsx +++ b/superset-frontend/src/explore/components/controls/ConditionalFormattingControl/ConditionalFormattingControl.tsx @@ -53,7 +53,6 @@ export const FormatterContainer = styled(OptionControlContainer)` export const CloseButton = styled.button` ${({ theme }) => css` - color: ${theme.colorIcon}; height: 100%; width: ${theme.sizeUnit * 6}px; border: none; From f739c355034b14f47b9c0cc79bcc4b0b885a8908 Mon Sep 17 00:00:00 2001 From: Mehmet Salih Yavuz Date: Tue, 23 Sep 2025 10:34:01 +0300 Subject: [PATCH 2/2] fix: custom colors --- .../ConditionalFormattingControl.tsx | 2 ++ 1 file changed, 2 insertions(+) diff --git a/superset-frontend/src/explore/components/controls/ConditionalFormattingControl/ConditionalFormattingControl.tsx b/superset-frontend/src/explore/components/controls/ConditionalFormattingControl/ConditionalFormattingControl.tsx index e15346156974..25e38d5f97f0 100644 --- a/superset-frontend/src/explore/components/controls/ConditionalFormattingControl/ConditionalFormattingControl.tsx +++ b/superset-frontend/src/explore/components/controls/ConditionalFormattingControl/ConditionalFormattingControl.tsx @@ -53,6 +53,8 @@ export const FormatterContainer = styled(OptionControlContainer)` export const CloseButton = styled.button` ${({ theme }) => css` + background: ${theme.colorBgLayout}; + color: ${theme.colorIcon}; height: 100%; width: ${theme.sizeUnit * 6}px; border: none;