From 4ce79e181da8ec6ce284b85318938aa0df72b07a Mon Sep 17 00:00:00 2001 From: Rafael Benitez Date: Fri, 22 Aug 2025 15:29:16 -0400 Subject: [PATCH] fix: - Icons in ExecutionLogList fixed - In county map chart tooltip fixed to match theme --- .../src/ReactCountryMap.jsx | 2 + .../alerts/components/AlertStatusIcon.tsx | 38 ++++++++++++------- 2 files changed, 27 insertions(+), 13 deletions(-) diff --git a/superset-frontend/plugins/legacy-plugin-chart-country-map/src/ReactCountryMap.jsx b/superset-frontend/plugins/legacy-plugin-chart-country-map/src/ReactCountryMap.jsx index ba8f06eaebf6..9d8413b4275c 100644 --- a/superset-frontend/plugins/legacy-plugin-chart-country-map/src/ReactCountryMap.jsx +++ b/superset-frontend/plugins/legacy-plugin-chart-country-map/src/ReactCountryMap.jsx @@ -58,11 +58,13 @@ export default styled(CountryMap)` } .superset-legacy-chart-country-map text.result-text { + fill: ${theme.colorText}; font-weight: ${theme.fontWeightLight}; font-size: ${theme.fontSizeXL}px; } .superset-legacy-chart-country-map text.big-text { + fill: ${theme.colorText}; font-weight: ${theme.fontWeightStrong}; font-size: ${theme.fontSizeLG}px; } diff --git a/superset-frontend/src/features/alerts/components/AlertStatusIcon.tsx b/superset-frontend/src/features/alerts/components/AlertStatusIcon.tsx index 1258ea6aad57..ccec4ddf5c58 100644 --- a/superset-frontend/src/features/alerts/components/AlertStatusIcon.tsx +++ b/superset-frontend/src/features/alerts/components/AlertStatusIcon.tsx @@ -16,7 +16,7 @@ * specific language governing permissions and limitations * under the License. */ -import { t, SupersetTheme, useTheme } from '@superset-ui/core'; +import { t, SupersetTheme, useTheme, css } from '@superset-ui/core'; import { Tooltip } from '@superset-ui/core/components'; import { Icons } from '@superset-ui/core/components/Icons'; import { AlertState } from '../types'; @@ -32,7 +32,7 @@ function getStatusColor( case AlertState.Error: return theme.colorErrorText; case AlertState.Success: - return isReportEnabled ? theme.colorSuccessText : theme.colorErrorText; + return theme.colorSuccessText; case AlertState.Noop: return theme.colorSuccessText; case AlertState.Grace: @@ -57,9 +57,7 @@ export default function AlertStatusIcon({ }; switch (state) { case AlertState.Success: - lastStateConfig.icon = isReportEnabled - ? Icons.CheckOutlined - : Icons.WarningOutlined; + lastStateConfig.icon = Icons.CheckOutlined; lastStateConfig.label = isReportEnabled ? t('Report sent') : t('Alert triggered, notification sent'); @@ -95,16 +93,30 @@ export default function AlertStatusIcon({ lastStateConfig.status = AlertState.Noop; } const Icon = lastStateConfig.icon; + const isRunningIcon = state === AlertState.Working; return ( - + + + ); }