diff --git a/superset-frontend/src/dashboard/components/FiltersBadge/DetailsPanel/index.tsx b/superset-frontend/src/dashboard/components/FiltersBadge/DetailsPanel/index.tsx index 40b4da99c920..18081ca2cb55 100644 --- a/superset-frontend/src/dashboard/components/FiltersBadge/DetailsPanel/index.tsx +++ b/superset-frontend/src/dashboard/components/FiltersBadge/DetailsPanel/index.tsx @@ -20,7 +20,7 @@ import { RefObject, useEffect, useRef, KeyboardEvent } from 'react'; import { useSelector } from 'react-redux'; import { t, useTheme } from '@superset-ui/core'; -import { Popover } from '@superset-ui/core/components'; +import { List, Popover } from '@superset-ui/core/components'; import { FiltersContainer, FiltersDetailsContainer, @@ -158,14 +158,19 @@ const DetailsPanelPopover = ({ {t('Applied filters (%d)', appliedIndicators.length)} - {appliedIndicators.map(indicator => ( - indicatorRefs.current.push(el)} - key={indicatorKey(indicator)} - indicator={indicator} - onClick={onHighlightFilterSource} - /> - ))} + ( + + indicatorRefs.current.push(el)} + key={indicatorKey(indicator)} + indicator={indicator} + onClick={onHighlightFilterSource} + /> + + )} + /> ) : null} diff --git a/superset-frontend/src/dashboard/components/FiltersBadge/Styles.tsx b/superset-frontend/src/dashboard/components/FiltersBadge/Styles.tsx index b58b5d27d851..9c67f1f7f87d 100644 --- a/superset-frontend/src/dashboard/components/FiltersBadge/Styles.tsx +++ b/superset-frontend/src/dashboard/components/FiltersBadge/Styles.tsx @@ -103,6 +103,7 @@ export const FilterItem = styled.button` export const FiltersContainer = styled.div` ${({ theme }) => css` + max-height: 60vh; margin-top: ${theme.sizeUnit}px; &:not(:last-child) { padding-bottom: ${theme.sizeUnit * 3}px; @@ -116,7 +117,7 @@ export const FiltersDetailsContainer = styled.div` max-width: 300px; overflow-x: hidden; - color: ${theme.colorBgBase}; + color: ${theme.colorText}; `} `;