-
Notifications
You must be signed in to change notification settings - Fork 16.2k
feat(deckgl): add support for OpenStreetMap as our new default and make "tile-providers" more configurable FIX #34204
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
…ke tile-providers more configurable FIX1
08872c8 to
e7d233d
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #34204 +/- ##
===========================================
+ Coverage 0 72.95% +72.95%
===========================================
Files 0 561 +561
Lines 0 40603 +40603
Branches 0 4270 +4270
===========================================
+ Hits 0 29621 +29621
- Misses 0 9864 +9864
- Partials 0 1118 +1118
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
…ke tile-providers more configurable FIX4
…ke tile-providers more configurable FIX4
…ke tile-providers more configurable FIX5
…ke tile-providers more configurable FIX6
…ke tile-providers more configurable FIX7
|
@mistercrunch I have solved the pb with #34176 |
mistercrunch
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks much for tackling this!
…ke "tile-providers" more configurable FIX (apache#34204)
SUMMARY
This PR introduces support for OpenStreetMap as the tile provider behind deckgl charts. It also changes the default tile-provider to be OpenStreetMap, since Mapbox isn't as open and requires configuration + an API key. This PR makes tile-providers configurable, so it's possible for those who have an API key and prefer Mapbox to match the default as of before-this-PR.
Changing defaults here is a "breaking change" in the sense that the default is changing, but you can reproduce the previous behavior with a bit of documented configuration.
BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
TESTING INSTRUCTIONS
In config.py set the following
And in TALISMAN_DEV_CONF
add "https://c.tile.openstreetmap.org" to 'connect-src' array
ADDITIONAL INFORMATION