Skip to content

Conversation

@plavacquery
Copy link
Contributor

@plavacquery plavacquery commented Jul 17, 2025

SUMMARY

This PR introduces support for OpenStreetMap as the tile provider behind deckgl charts. It also changes the default tile-provider to be OpenStreetMap, since Mapbox isn't as open and requires configuration + an API key. This PR makes tile-providers configurable, so it's possible for those who have an API key and prefer Mapbox to match the default as of before-this-PR.

Changing defaults here is a "breaking change" in the sense that the default is changing, but you can reproduce the previous behavior with a bit of documented configuration.

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

image

TESTING INSTRUCTIONS

In config.py set the following

DECKGL_BASE_MAP = [
     ['https://c.tile.openstreetmap.org/{z}/{x}/{y}.png', 'OpenStreetMap' ],
]

ENABLE_CORS = True
CORS_OPTIONS: dict[Any, Any] = {
    "origins": [
        "https://c.tile.openstreetmap.org",
    ]
}

And in TALISMAN_DEV_CONF
add "https://c.tile.openstreetmap.org" to 'connect-src' array

ADDITIONAL INFORMATION

@github-actions github-actions bot added doc Namespace | Anything related to documentation plugins dependencies:npm packages labels Jul 17, 2025
@plavacquery plavacquery changed the title feat(deckgl): add support for OpenStreetMap as our new default and ma… feat(deckgl): add support for OpenStreetMap as our new default and make "tile-providers" more configurable FIX Jul 17, 2025
@dosubot dosubot bot added risk:breaking-change Issues or PRs that will introduce breaking changes viz:charts:deck.gl Related to deck.gl charts labels Jul 17, 2025
@korbit-ai
Copy link

korbit-ai bot commented Jul 17, 2025

I was unable to post the issues I found. This could be because a force push or squash has changed the commit history since I scanned this pull request. You can get another review by commenting /korbit-review.

@codecov
Copy link

codecov bot commented Jul 17, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 72.95%. Comparing base (96cb603) to head (11abdf0).
Report is 9 commits behind head on master.

Additional details and impacted files
@@             Coverage Diff             @@
##           master   #34204       +/-   ##
===========================================
+ Coverage        0   72.95%   +72.95%     
===========================================
  Files           0      561      +561     
  Lines           0    40603    +40603     
  Branches        0     4270     +4270     
===========================================
+ Hits            0    29621    +29621     
- Misses          0     9864     +9864     
- Partials        0     1118     +1118     
Flag Coverage Δ
hive 47.17% <100.00%> (?)
mysql 71.94% <100.00%> (?)
postgres 71.99% <100.00%> (?)
presto 50.91% <100.00%> (?)
python 72.91% <100.00%> (?)
sqlite 71.53% <100.00%> (?)
unit 100.00% <ø> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@plavacquery
Copy link
Contributor Author

plavacquery commented Jul 18, 2025

@mistercrunch I have solved the pb with #34176

Copy link
Member

@mistercrunch mistercrunch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks much for tackling this!

@mistercrunch mistercrunch merged commit da6947d into apache:master Jul 18, 2025
61 checks passed
dankor pushed a commit to dankor/superset that referenced this pull request Aug 18, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

dependencies:npm doc Namespace | Anything related to documentation packages plugins risk:breaking-change Issues or PRs that will introduce breaking changes size/L viz:charts:deck.gl Related to deck.gl charts

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Superset Map visualization deck.gl Scatter plot does not work and not shown

2 participants