feat(deckgl): REREVERT: add support for OpenStreetMap as our new default and ke "tile-providers" more configurable #34176

mistercrunch · 2025-07-15T17:07:30Z

Somehow this PR #34017 reverted a bunch of stuff from #33603 , guessing this was a badly resolved merge conflict and people missed in around review/merge

…ke "tile-providers" more configurable (#33603) Co-authored-by: Maxime Beauchemin <[email protected]>

korbit-ai

Review by Korbit AI

Korbit automatically attempts to detect when you fix issues in new commits.

Category	Issue	Status
	Incomplete Warning About Configuration Override ▹ view	🧠 Not in scope
	Incorrect Configuration Key for OSM Tiles ▹ view	🧠 Not in standard
	Missing Default Value for Map Tiles Configuration ▹ view	🧠 Not in scope
	Improper Sentence Structure ▹ view	🧠 Not in scope
	Unclear Documentation Grammar ▹ view	🧠 Not in standard
	Unclear Parameter Name Abbreviation ▹ view	🧠 Incorrect
	Incorrect CORS Origin Format ▹ view	🧠 Not in scope
	Props Mutation in Tile Layer Addition ▹ view	🧠 Not in scope
	Hard-to-Parse Conditional Logic ▹ view	🧠 Not in scope
	Unvalidated Tile Source URL ▹ view	🧠 Incorrect

Files scanned

File Path	Reviewed
superset-frontend/packages/superset-ui-core/src/validator/validateMapboxStylesUrl.ts	✅
superset/examples/misc_dashboard.py	✅
docs/docs/configuration/map-tiles.mdx	✅
superset/examples/long_lat.py	✅
superset-frontend/plugins/legacy-preset-chart-deckgl/src/DeckGLContainer.tsx	✅
superset-frontend/plugins/legacy-preset-chart-deckgl/src/utils.ts	✅
superset-frontend/plugins/legacy-preset-chart-deckgl/src/utilities/Shared_DeckGL.tsx	✅
superset/views/base.py	✅
superset/examples/deck.py	✅
superset/config.py	✅

Explore our documentation to understand the languages and file types we support and the files we ignore.

Check out our docs on how you can make Korbit work best for you and your team.

Loving Korbit!? Share us on LinkedIn Reddit and X

docs/docs/configuration/map-tiles.mdx

+
+# Map tiles
+
+Superset uses OSM and Mapbox tiles by default. OSM is free but you still need setting your MAPBOX_API_KEY if you want to use mapbox maps.


superset-frontend/plugins/legacy-preset-chart-deckgl/src/DeckGLContainer.tsx

    const layers = useCallback(() => {
+      if (
+        (props.mapStyle?.startsWith(TILE_LAYER_PREFIX) ||
+          OSM_LAYER_KEYWORDS.some(tilek => props.mapStyle?.includes(tilek))) &&


docs/docs/configuration/map-tiles.mdx

+CORS_OPTIONS: dict[Any, Any] = {
+    "origins": [
+        "https://tile.openstreetmap.org",
+        "https://tile.osm.ch",
+        "https://your_personal_url/{z}/{x}/{y}.png",
+    ]
+}


docs/docs/configuration/map-tiles.mdx

+Map tiles can be set with `DECKGL_BASE_MAP` in your `superset_config.py` or `superset_config_docker.py`
+For adding your own map tiles, you can use the following format.


docs/docs/configuration/map-tiles.mdx

+:::warning
+Setting `DECKGL_BASE_MAP` overwrite default values
+:::


superset/examples/long_lat.py

        "all_columns_x": "LON",
        "all_columns_y": "LAT",
-        "mapbox_style": "mapbox://styles/mapbox/light-v9",
+        "mapbox_style": "https://tile.openstreetmap.org/{z}/{x}/{y}.png",


superset/views/base.py

        "d3_format": conf.get("D3_FORMAT"),
        "d3_time_format": conf.get("D3_TIME_FORMAT"),
        "currencies": conf.get("CURRENCIES"),
+        "deckgl_tiles": conf.get("DECKGL_BASE_MAP"),


superset-frontend/plugins/legacy-preset-chart-deckgl/src/DeckGLContainer.tsx

+        props.layers.unshift(
+          buildTileLayer(
+            (props.mapStyle ?? '').replace(TILE_LAYER_PREFIX, ''),
+            'tile-layer',
+          ),
+        );


superset-frontend/plugins/legacy-preset-chart-deckgl/src/DeckGLContainer.tsx

+      if (
+        (props.mapStyle?.startsWith(TILE_LAYER_PREFIX) ||
+          OSM_LAYER_KEYWORDS.some(tilek => props.mapStyle?.includes(tilek))) &&
+        props.layers.some(
+          l => typeof l !== 'function' && l?.id === 'tile-layer',
+        ) === false
+      ) {


superset-frontend/plugins/legacy-preset-chart-deckgl/src/utils.ts

+export function buildTileLayer(url: string, id: string) {
+  interface TileLayerProps {
+    id: string;
+    data: string;
+    minZoom: number;
+    maxZoom: number;
+    tileSize: number;
+    renderSubLayers: (props: any) => (BitmapLayer | PathLayer)[];
+  }
+
+  interface RenderSubLayerProps {
+    tile: {
+      bbox: GeoBoundingBox;
+    };
+    data: any;
+  }
+
+  return new TileLayer({
+    data: url,
+    id,
+    minZoom: 0,
+    maxZoom: 19,
+    tileSize: 256,


plavacquery · 2025-07-16T14:55:46Z

@mistercrunch I have somehow fixed the problem when printing deckgl map
I added on root package.json

    "@luma.gl/constants": "^9.1.9",
    "@luma.gl/core": "^9.1.9",
    "@luma.gl/engine": "^9.1.9",
    "@luma.gl/shadertools": "^9.1.9",
    "@luma.gl/webgl": "^9.1.9",
    "deck.gl": "^9.1.13",

and also set deckgl library version in folder legacy-preset-chart-deckg to 9.1.3,
and then regenerated package-lock.json

plavacquery · 2025-07-16T18:59:33Z

@mistercrunch Is it possible to get access to this PR, so I can contribute for fixing ?

mistercrunch · 2025-07-16T23:46:07Z

@mistercrunch Is it possible to get access to this PR, so I can contribute for fixing ?

Unfortunately I can't give you access to the ASF (apache) org, there's a complex process to do this and it's managed by the ASF, but you can open a new PR from your fork, happy to close this one in favor of yours.

Can also try to put in your suggested fix in package.json real quick. Giving it a quick shot but don't want to block you if you want to open a new PR.

mistercrunch · 2025-07-16T23:51:14Z

I added on root package.json

Seems this belongs in superset-frontend/plugins/legacy-preset-chart-deckgl/package.json, and probably better to use the sub-packages of deck-gl to specify exactly what we need (unless that's causing the problem).

I'll push my interpretation of your fix to see if it works ... Feel free to fork but make sure to add deck.gl libs in the plugin not the main app...

mistercrunch · 2025-07-16T23:55:02Z

superset-frontend/plugins/legacy-preset-chart-deckgl/package.json

-    "@deck.gl/core": "^9.0.37",
-    "@deck.gl/layers": "^9.0.38",
-    "@deck.gl/react": "^9.1.4",
+    "@deck.gl/aggregation-layers": "^9.1.13",


@plavacquery trying your suggested fix (upgraded to 9.1.13) while keeping the sub-packages, and adding luma.gl deps explicitely

mistercrunch · 2025-07-17T00:01:05Z

Tried a few things locally and bumped into dep hell, passing the baton as I can't take this on RN. @plavacquery please open a new PR from your fork if you can. Still hoping we can push forward.

mistercrunch · 2025-07-17T00:29:14Z

Oh, this didn't work locally but seems to work on CI, the hypothesis around getting node_modules/ tangled up seems right, broke locally but PR / CI is working from a clean slate. Might be easy to fix the couple unit tests failing here. Could be related to the lib upgrade.

mistercrunch · 2025-07-17T00:34:37Z

Seems to be pointing around webpack / mapbox / es6 support...

Josee-xav · 2025-07-22T11:53:16Z

I was struggling to get openstreetmaps to be default view to work with the pip superset version by changing settings but it just wouldnt work. Your github changes made getting openstreetmaps to work perfectly without much trouble.

If anyone is struggling to get it to work the only thing i needed to do is:

#32187
cd superset-frontend/
npm install -f --no-optional --global webpack webpack-cli
npm install -f --no-optional
npm install -f --global webpack webpack-cli
npm install -f
npm run dev
cd ..

.
edit- latest version of superset still uses mapbox! absolutely ridiculous.
.
for future self or other people. to get the OSM working i had to git clone
https://github.com/plavacquery/superset/tree/config-map-tiles2

that specific one as the config-map-tiles sql lab didnt work so well and then follow
https://superset.apache.org/docs/contributing/development/
flask server

mistercrunch · 2025-07-22T19:23:07Z

Another PR tackled this, closing

feat(deckgl): add support for OpenStreetMap as our new default and ma…

5018667

…ke "tile-providers" more configurable (#33603) Co-authored-by: Maxime Beauchemin <[email protected]>

pull-request-size bot added the size/L label Jul 15, 2025

github-actions bot added doc Namespace | Anything related to documentation plugins dependencies:npm packages labels Jul 15, 2025

mistercrunch mentioned this pull request Jul 15, 2025

feat(deckgl): add support for OpenStreetMap as our new default and make "tile-providers" more configurable #33603

Merged

9 tasks

dosubot bot added risk:breaking-change Issues or PRs that will introduce breaking changes viz:charts:deck.gl Related to deck.gl charts labels Jul 15, 2025

remove .[cors]

732853f

mistercrunch mentioned this pull request Jul 15, 2025

feat(deckgl): add new color controls with color breakpoints #34017

Merged

9 tasks

korbit-ai bot reviewed Jul 15, 2025

View reviewed changes

michael-s-molina requested review from betodealmeida and kgabryje July 15, 2025 17:32

michael-s-molina added the review:checkpoint Last PR reviewed during the daily review standup label Jul 15, 2025

trying a variation on suggested fix

542efb5

mistercrunch commented Jul 16, 2025

View reviewed changes

sloppy fix to tsc type error

2b4d5b8

sadpandajoe removed the review:checkpoint Last PR reviewed during the daily review standup label Jul 17, 2025

plavacquery mentioned this pull request Jul 18, 2025

feat(deckgl): add support for OpenStreetMap as our new default and make "tile-providers" more configurable FIX #34204

Merged

9 tasks

mistercrunch closed this Jul 22, 2025


		# Map tiles

		Superset uses OSM and Mapbox tiles by default. OSM is free but you still need setting your MAPBOX_API_KEY if you want to use mapbox maps.

		Map tiles can be set with `DECKGL_BASE_MAP` in your `superset_config.py` or `superset_config_docker.py`
		For adding your own map tiles, you can use the following format.

feat(deckgl): REREVERT: add support for OpenStreetMap as our new default and ke "tile-providers" more configurable #34176

feat(deckgl): REREVERT: add support for OpenStreetMap as our new default and ke "tile-providers" more configurable #34176

Uh oh!

Conversation

mistercrunch commented Jul 15, 2025

Uh oh!

korbit-ai bot left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Review by Korbit AI

Korbit automatically attempts to detect when you fix issues in new commits.

Uh oh!

This comment was marked as resolved.

Uh oh!

This comment was marked as resolved.

Uh oh!

This comment was marked as resolved.

Uh oh!

This comment was marked as resolved.

Uh oh!

This comment was marked as resolved.

Uh oh!

This comment was marked as resolved.

Uh oh!

This comment was marked as resolved.

Uh oh!

This comment was marked as resolved.

Uh oh!

This comment was marked as resolved.

Uh oh!

This comment was marked as resolved.

Uh oh!

plavacquery commented Jul 16, 2025

Uh oh!

plavacquery commented Jul 16, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

mistercrunch commented Jul 16, 2025

Uh oh!

mistercrunch commented Jul 16, 2025

Uh oh!

mistercrunch Jul 16, 2025

Choose a reason for hiding this comment

Uh oh!

mistercrunch commented Jul 17, 2025

Uh oh!

mistercrunch commented Jul 17, 2025

Uh oh!

mistercrunch commented Jul 17, 2025

Uh oh!

Josee-xav commented Jul 22, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

mistercrunch commented Jul 22, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

korbit-ai bot left a comment •

edited

Loading

plavacquery commented Jul 16, 2025 •

edited

Loading

Josee-xav commented Jul 22, 2025 •

edited

Loading