diff --git a/superset-frontend/spec/javascripts/datasource/DatasourceModal_spec.jsx b/superset-frontend/spec/javascripts/datasource/DatasourceModal_spec.jsx
index 18890c578473..9d4d9c638ed2 100644
--- a/superset-frontend/spec/javascripts/datasource/DatasourceModal_spec.jsx
+++ b/superset-frontend/spec/javascripts/datasource/DatasourceModal_spec.jsx
@@ -39,6 +39,7 @@ const datasource = mockDatasource['7__table'];
const SAVE_ENDPOINT = 'glob:*/api/v1/dataset/7';
const SAVE_PAYLOAD = { new: 'data' };
+const SAVE_DATASOURCE_ENDPOINT = 'glob:*/datasource/save/';
const mockedProps = {
datasource,
@@ -94,6 +95,7 @@ describe('DatasourceModal', () => {
it('saves on confirm', async () => {
const callsP = fetchMock.post(SAVE_ENDPOINT, SAVE_PAYLOAD);
+ fetchMock.post(SAVE_DATASOURCE_ENDPOINT, {});
act(() => {
wrapper
.find('button[data-test="datasource-modal-save"]')
diff --git a/superset-frontend/spec/javascripts/explore/components/AdhocMetricEditPopover_spec.jsx b/superset-frontend/spec/javascripts/explore/components/AdhocMetricEditPopover_spec.jsx
index 59bc07c76528..3930de3231c7 100644
--- a/superset-frontend/spec/javascripts/explore/components/AdhocMetricEditPopover_spec.jsx
+++ b/superset-frontend/spec/javascripts/explore/components/AdhocMetricEditPopover_spec.jsx
@@ -51,7 +51,7 @@ function setup(overrides) {
const onClose = sinon.spy();
const props = {
adhocMetric: sumValueAdhocMetric,
- savedMetric: {},
+ savedMetric: { metric_name: 'foo', expression: 'COUNT(*)' },
savedMetrics: [],
onChange,
onClose,
diff --git a/superset-frontend/spec/javascripts/explore/components/ColorPickerControl_spec.jsx b/superset-frontend/spec/javascripts/explore/components/ColorPickerControl_spec.jsx
index 4d675c738bd9..f9822bf338e4 100644
--- a/superset-frontend/spec/javascripts/explore/components/ColorPickerControl_spec.jsx
+++ b/superset-frontend/spec/javascripts/explore/components/ColorPickerControl_spec.jsx
@@ -34,7 +34,7 @@ const defaultProps = {
describe('ColorPickerControl', () => {
let wrapper;
let inst;
- beforeEach(() => {
+ beforeAll(() => {
getCategoricalSchemeRegistry()
.registerValue(
'test',
diff --git a/superset-frontend/spec/javascripts/explore/components/DatasourcePanel_spec.jsx b/superset-frontend/spec/javascripts/explore/components/DatasourcePanel_spec.jsx
index 1bfd67ad2682..784e10581448 100644
--- a/superset-frontend/spec/javascripts/explore/components/DatasourcePanel_spec.jsx
+++ b/superset-frontend/spec/javascripts/explore/components/DatasourcePanel_spec.jsx
@@ -45,7 +45,7 @@ describe('datasourcepanel', () => {
datasource,
},
},
- actions: null,
+ actions: {},
};
it('should render', () => {
const { container } = render(
diff --git a/superset-frontend/spec/javascripts/explore/components/ExploreChartHeader_spec.jsx b/superset-frontend/spec/javascripts/explore/components/ExploreChartHeader_spec.jsx
index 023b0796ff86..afa33d0d0647 100644
--- a/superset-frontend/spec/javascripts/explore/components/ExploreChartHeader_spec.jsx
+++ b/superset-frontend/spec/javascripts/explore/components/ExploreChartHeader_spec.jsx
@@ -44,8 +44,10 @@ const mockProps = {
},
timeout: 1000,
chart: {
+ id: 0,
queryResponse: {},
},
+ chartHeight: '30px',
};
describe('ExploreChartHeader', () => {
diff --git a/superset-frontend/spec/javascripts/explore/components/MetricDefinitionOption_spec.jsx b/superset-frontend/spec/javascripts/explore/components/MetricDefinitionOption_spec.jsx
index d1a93df6655a..7b950e8cf01e 100644
--- a/superset-frontend/spec/javascripts/explore/components/MetricDefinitionOption_spec.jsx
+++ b/superset-frontend/spec/javascripts/explore/components/MetricDefinitionOption_spec.jsx
@@ -33,7 +33,9 @@ describe('MetricDefinitionOption', () => {
}
it('renders a MetricOption given a saved metric', () => {
- const wrapper = setup({ option: { metric_name: 'a_saved_metric' } });
+ const wrapper = setup({
+ option: { metric_name: 'a_saved_metric', expression: 'COUNT(*)' },
+ });
expect(wrapper.find(MetricOption)).toExist();
});
diff --git a/superset-frontend/spec/javascripts/explore/components/MetricDefinitionValue_spec.jsx b/superset-frontend/spec/javascripts/explore/components/MetricDefinitionValue_spec.jsx
index f2e038e77db4..9c9a652d94fa 100644
--- a/superset-frontend/spec/javascripts/explore/components/MetricDefinitionValue_spec.jsx
+++ b/superset-frontend/spec/javascripts/explore/components/MetricDefinitionValue_spec.jsx
@@ -33,7 +33,11 @@ const sumValueAdhocMetric = new AdhocMetric({
describe('MetricDefinitionValue', () => {
it('renders a MetricOption given a saved metric', () => {
const wrapper = shallow(
- ,
+ {}}
+ option={{ metric_name: 'a_saved_metric', expression: 'COUNT(*)' }}
+ index={1}
+ />,
);
expect(wrapper.find('AdhocMetricOption')).toExist();
});
@@ -43,6 +47,7 @@ describe('MetricDefinitionValue', () => {
{}}
option={sumValueAdhocMetric}
+ index={1}
/>,
);
expect(wrapper.find(AdhocMetricOption)).toExist();
diff --git a/superset-frontend/spec/javascripts/sqllab/SqlEditor_spec.jsx b/superset-frontend/spec/javascripts/sqllab/SqlEditor_spec.jsx
index d472030d332d..eca063c7f4db 100644
--- a/superset-frontend/spec/javascripts/sqllab/SqlEditor_spec.jsx
+++ b/superset-frontend/spec/javascripts/sqllab/SqlEditor_spec.jsx
@@ -55,6 +55,7 @@ describe('SqlEditor', () => {
dataPreviewQueries: [],
defaultQueryLimit: 1000,
maxRow: 100000,
+ displayLimit: 100,
};
const buildWrapper = (props = {}) =>