diff --git a/superset-frontend/src/SqlLab/components/EstimateQueryCostButton.jsx b/superset-frontend/src/SqlLab/components/EstimateQueryCostButton.jsx index a8e794fffa10..9de78089a3f0 100644 --- a/superset-frontend/src/SqlLab/components/EstimateQueryCostButton.jsx +++ b/superset-frontend/src/SqlLab/components/EstimateQueryCostButton.jsx @@ -95,7 +95,6 @@ class EstimateQueryCostButton extends React.PureComponent { {btnText} } - bsSize="medium" /> ); diff --git a/superset-frontend/src/SqlLab/components/ScheduleQueryButton.jsx b/superset-frontend/src/SqlLab/components/ScheduleQueryButton.jsx index dd91996086f7..08fd388df990 100644 --- a/superset-frontend/src/SqlLab/components/ScheduleQueryButton.jsx +++ b/superset-frontend/src/SqlLab/components/ScheduleQueryButton.jsx @@ -201,7 +201,6 @@ class ScheduleQueryButton extends React.PureComponent { {t('Schedule')} } - bsSize="medium" /> ); diff --git a/superset-frontend/src/components/DeleteModal.tsx b/superset-frontend/src/components/DeleteModal.tsx index 8a9cd16d5e33..d142ce1d943d 100644 --- a/superset-frontend/src/components/DeleteModal.tsx +++ b/superset-frontend/src/components/DeleteModal.tsx @@ -63,7 +63,6 @@ export default function DeleteModal({ primaryButtonType="danger" show={open} title={title} - bsSize="medium" > {description} diff --git a/superset-frontend/src/components/Modal.tsx b/superset-frontend/src/components/Modal.tsx index f9d2faed9ccb..fb7edb5ddd4e 100644 --- a/superset-frontend/src/components/Modal.tsx +++ b/superset-frontend/src/components/Modal.tsx @@ -31,7 +31,7 @@ interface ModalProps { primaryButtonType?: 'primary' | 'danger'; show: boolean; title: React.ReactNode; - bsSize?: 'xs' | 'xsmall' | 'sm' | 'small' | 'medium' | 'lg' | 'large'; + bsSize?: 'small' | 'large'; // react-bootstrap also supports 'sm', 'lg' but we're keeping it simple. } const StyledModal = styled(BaseModal)` @@ -75,10 +75,9 @@ export default function Modal({ primaryButtonType = 'primary', show, title, - bsSize = 'lg', }: ModalProps) { return ( - + {title} diff --git a/superset-frontend/src/components/ModalTrigger.jsx b/superset-frontend/src/components/ModalTrigger.jsx index d5e493af487b..1a7ddd101d63 100644 --- a/superset-frontend/src/components/ModalTrigger.jsx +++ b/superset-frontend/src/components/ModalTrigger.jsx @@ -34,7 +34,7 @@ const propTypes = { onExit: PropTypes.func, isButton: PropTypes.bool, isMenuItem: PropTypes.bool, - bsSize: PropTypes.string, + bsSize: PropTypes.oneOf(['large', 'small']), // react-bootstrap also supports 'sm', 'lg' but we're keeping it simple. className: PropTypes.string, tooltip: PropTypes.string, backdrop: PropTypes.oneOf(['static', true, false]), diff --git a/superset-frontend/src/datasource/ChangeDatasourceModal.tsx b/superset-frontend/src/datasource/ChangeDatasourceModal.tsx index 0b56bd239de0..a63efadee126 100644 --- a/superset-frontend/src/datasource/ChangeDatasourceModal.tsx +++ b/superset-frontend/src/datasource/ChangeDatasourceModal.tsx @@ -120,7 +120,7 @@ const ChangeDatasourceModal: FunctionComponent = ({ }; return ( - + {t('Select a datasource')} diff --git a/superset-frontend/src/datasource/DatasourceModal.tsx b/superset-frontend/src/datasource/DatasourceModal.tsx index c42689ec6e25..19ea9d826775 100644 --- a/superset-frontend/src/datasource/DatasourceModal.tsx +++ b/superset-frontend/src/datasource/DatasourceModal.tsx @@ -110,7 +110,7 @@ const DatasourceModal: FunctionComponent = ({ }; return ( - +
diff --git a/superset-frontend/src/explore/components/controls/VizTypeControl.jsx b/superset-frontend/src/explore/components/controls/VizTypeControl.jsx index cf5ad648f3ed..513b6b541ce9 100644 --- a/superset-frontend/src/explore/components/controls/VizTypeControl.jsx +++ b/superset-frontend/src/explore/components/controls/VizTypeControl.jsx @@ -213,7 +213,7 @@ export default class VizTypeControl extends React.PureComponent { onHide={this.toggleModal} onEnter={this.focusSearch} onExit={this.setSearchRef} - bsSize="lg" + bsSize="large" > {t('Select a visualization type')}