Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(dashboard filters): add "previous quarter" as option #30506

Open
wants to merge 9 commits into
base: master
Choose a base branch
from

Conversation

personofnorank
Copy link

@personofnorank personofnorank commented Oct 3, 2024

SUMMARY

The custom date range filter should include previous quarter along with previous calendar week, month or year

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

TESTING INSTRUCTIONS

ADDITIONAL INFORMATION

  • Has associated issue: [SIP-116] Simplifying time period filtering for users  #26651
  • Required feature flags:
  • Changes UI
  • Includes DB Migration (follow approval process in SIP-59)
    • Migration is atomic, supports rollback & is backwards-compatible
    • Confirm DB migration upgrade and downgrade tested
    • Runtime estimates and downtime expectations provided
  • Introduces new feature or API
  • Removes existing feature or API

@dosubot dosubot bot added change:frontend Requires changing the frontend explore:time Related to the time filters in Explore labels Oct 3, 2024
@personofnorank
Copy link
Author

@sfirke as per Slack discussion, thank you!

Copy link
Contributor

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Congrats on making your first PR and thank you for contributing to Superset! 🎉 ❤️

We hope to see you in our Slack community too! Not signed up? Use our Slack App to self-register.

@sfirke
Copy link
Member

sfirke commented Oct 3, 2024

Thank you! This repository requires PR titles to follow Conventional Commit format (I think it's called). For this one it could be:

fix(dashboard filters): add "previous quarter" as option

That will cause CI failure until fixed.

I'm off work today but maybe someone else will review, otherwise I'll look when I'm back.

@personofnorank personofnorank changed the title Previous quarter option for custom date filter fix(dashboard filters): add "previous quarter" as option Oct 3, 2024
@pull-request-size pull-request-size bot added size/S and removed size/XS labels Oct 3, 2024
Copy link

codecov bot commented Oct 3, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 77.39%. Comparing base (76d897e) to head (13db748).
Report is 830 commits behind head on master.

Additional details and impacted files
@@             Coverage Diff             @@
##           master   #30506       +/-   ##
===========================================
+ Coverage   60.48%   77.39%   +16.90%     
===========================================
  Files        1931      533     -1398     
  Lines       76236    38533    -37703     
  Branches     8568        0     -8568     
===========================================
- Hits        46114    29823    -16291     
+ Misses      28017     8710    -19307     
+ Partials     2105        0     -2105     
Flag Coverage Δ
hive 49.00% <ø> (-0.17%) ⬇️
javascript ?
mysql 76.86% <ø> (?)
postgres 76.94% <ø> (?)
presto 53.50% <ø> (-0.31%) ⬇️
python 77.39% <ø> (+13.90%) ⬆️
sqlite 76.38% <ø> (?)
unit ?

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@pull-request-size pull-request-size bot added size/M and removed size/S labels Oct 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
change:frontend Requires changing the frontend explore:time Related to the time filters in Explore packages size/M
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants