-
Notifications
You must be signed in to change notification settings - Fork 13.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor: Removes the deprecated VERSIONED_EXPORT feature flag #26347
refactor: Removes the deprecated VERSIONED_EXPORT feature flag #26347
Conversation
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## master #26347 +/- ##
==========================================
- Coverage 69.56% 67.25% -2.31%
==========================================
Files 1892 1892
Lines 74162 74107 -55
Branches 8263 8254 -9
==========================================
- Hits 51593 49843 -1750
- Misses 20488 22188 +1700
+ Partials 2081 2076 -5
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
@michael-s-molina should we put in the PR description and UPDATING.md what the flag currently defaults to? I think that would help people know what behavior to expect. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
SUMMARY
As part of the 4.0 approved initiatives, this PR removes the
VERSIONED_EXPORT
feature flag.The previous value of the feature flag was
True
and now the feature is permanently enabled.TESTING INSTRUCTIONS
CI should be sufficient for merging this PR. We'll do a complete testing of 4.0 after all approved proposals are merged.
ADDITIONAL INFORMATION