-
Notifications
You must be signed in to change notification settings - Fork 13.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor: Removes the deprecated ENABLE_TEMPLATE_REMOVE_FILTERS feature flag #26345
Merged
michael-s-molina
merged 3 commits into
apache:master
from
michael-s-molina:remove-template-remove-filters-ff
Jan 18, 2024
Merged
refactor: Removes the deprecated ENABLE_TEMPLATE_REMOVE_FILTERS feature flag #26345
michael-s-molina
merged 3 commits into
apache:master
from
michael-s-molina:remove-template-remove-filters-ff
Jan 18, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## master #26345 +/- ##
==========================================
- Coverage 69.07% 69.07% -0.01%
==========================================
Files 1930 1930
Lines 75300 75299 -1
Branches 8429 8429
==========================================
- Hits 52015 52014 -1
Misses 21138 21138
Partials 2147 2147
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
villebro
approved these changes
Dec 22, 2023
geido
approved these changes
Jan 5, 2024
Muhammed-baban
pushed a commit
to intellica-tech/reporting-tool
that referenced
this pull request
Jan 19, 2024
sfirke
pushed a commit
to sfirke/superset
that referenced
this pull request
Mar 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
🏷️ bot
A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels
risk:breaking-change
Issues or PRs that will introduce breaking changes
size/S
v4.0
Label added by the release manager to track PRs to be included in the 4.0 branch
🚢 4.0.0
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SUMMARY
As part of the 4.0 approved initiatives, this PR removes the
ENABLE_TEMPLATE_REMOVE_FILTERS
feature flag.The previous value of the feature flag was
True
and now the feature is permanently enabled.TESTING INSTRUCTIONS
CI should be sufficient for merging this PR. We'll do a complete testing of 4.0 after all approved proposals are merged.
ADDITIONAL INFORMATION