Skip to content

Conversation

@rxin
Copy link
Contributor

@rxin rxin commented May 28, 2015

See comments on #3913

@sryza
Copy link
Contributor

sryza commented May 28, 2015

LGTM. Sorry I didn't have a chance to get to this.

@sryza
Copy link
Contributor

sryza commented May 28, 2015

Actually, I believe the doc in the tuning section needs to be updated as well.

@sryza
Copy link
Contributor

sryza commented May 28, 2015

Scratch that last comment, the current wording still applies.

@SparkQA
Copy link

SparkQA commented May 28, 2015

Test build #33682 has finished for PR 6471 at commit c057095.

  • This patch fails PySpark unit tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@rxin
Copy link
Contributor Author

rxin commented May 28, 2015

The test failure looks different. I'm going to merge this.

asfgit pushed a commit that referenced this pull request May 28, 2015
See comments on #3913

Author: Reynold Xin <[email protected]>

Closes #6471 from rxin/sizeestimator and squashes the following commits:

c057095 [Reynold Xin] Fixed import.
2da478b [Reynold Xin] Remove SizeEstimator from o.a.spark package.

(cherry picked from commit 0077af2)
Signed-off-by: Reynold Xin <[email protected]>
@asfgit asfgit closed this in 0077af2 May 28, 2015
jeanlyn pushed a commit to jeanlyn/spark that referenced this pull request Jun 12, 2015
See comments on apache#3913

Author: Reynold Xin <[email protected]>

Closes apache#6471 from rxin/sizeestimator and squashes the following commits:

c057095 [Reynold Xin] Fixed import.
2da478b [Reynold Xin] Remove SizeEstimator from o.a.spark package.
nemccarthy pushed a commit to nemccarthy/spark that referenced this pull request Jun 19, 2015
See comments on apache#3913

Author: Reynold Xin <[email protected]>

Closes apache#6471 from rxin/sizeestimator and squashes the following commits:

c057095 [Reynold Xin] Fixed import.
2da478b [Reynold Xin] Remove SizeEstimator from o.a.spark package.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants