Skip to content

[SPARK-7118] [Python] Add the coalesce Spark SQL function available in PySpark #5698

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

[SPARK-7118] [Python] Add the coalesce Spark SQL function available in PySpark #5698

wants to merge 1 commit into from

Conversation

@ogirardot
Copy link

@ogirardot ogirardot commented Apr 25, 2015

This patch adds a proxy call from PySpark to the Spark SQL coalesce function and this patch comes out of a discussion on dev@spark with @rxin

This contribution is my original work and i license the work to the project under the project's open source license.

Olivier.

@rxin
Copy link
Contributor

rxin commented Apr 25, 2015

Jenkins, test this please.

@rxin
Copy link
Contributor

rxin commented Apr 25, 2015

LGTM also.

@ogirardot
Copy link
Author

ogirardot commented Apr 25, 2015

Somehow Jenkins doesn't seem to be build this PR : https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/

@ogirardot
Copy link
Author

ogirardot commented Apr 25, 2015

is this the job now ? https://amplab.cs.berkeley.edu/jenkins/job/NewSparkPullRequestBuilder/
triggered by https://spark-prs.appspot.com/ ?

@AmplabJenkins
Copy link

AmplabJenkins commented Apr 27, 2015

Can one of the admins verify this patch?

@ogirardot
Copy link
Author

ogirardot commented Apr 27, 2015

Jenkins, test this please. :)

@rxin
Copy link
Contributor

rxin commented Apr 27, 2015

Jenkins, test this please.

@ogirardot
Copy link
Author

ogirardot commented May 7, 2015

rebased properly :)

@rxin
Copy link
Contributor

rxin commented May 7, 2015

Jenkins, test this please.

@rxin
Copy link
Contributor

rxin commented May 7, 2015

Actually I think we changed the show() output format slightly, so you'd need to update the test case expected output.

@ogirardot
Copy link
Author

ogirardot commented May 7, 2015

can you launch jenkins and I'll change the test case accordingly ?

@AmplabJenkins
Copy link

AmplabJenkins commented May 7, 2015

Merged build triggered.

@AmplabJenkins
Copy link

AmplabJenkins commented May 7, 2015

Merged build started.

@SparkQA
Copy link

SparkQA commented May 7, 2015

Test build #32092 has started for PR 5698 at commit dd852b8.

@SparkQA
Copy link

SparkQA commented May 7, 2015

Test build #32092 has finished for PR 5698 at commit dd852b8.

  • This patch fails PySpark unit tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@AmplabJenkins
Copy link

AmplabJenkins commented May 7, 2015

Merged build finished. Test FAILed.

@AmplabJenkins
Copy link

AmplabJenkins commented May 7, 2015

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/32092/
Test FAILed.

SPARK-7118 Add the coalesce Spark SQL function available in PySpark
d9a4439 
No changes to the scala/java part, only changes in Python.
@ogirardot
Copy link
Author

ogirardot commented May 7, 2015

test is now fixed and using its own test variables

@ogirardot
Copy link
Author

ogirardot commented May 7, 2015

@pwendell do you mind launching the jenkins test, please ?

@pwendell
Copy link
Contributor

pwendell commented May 7, 2015

Jenkins, retest this please. Jenkins, add to whitelist.

@AmplabJenkins
Copy link

AmplabJenkins commented May 7, 2015

Merged build triggered.

@AmplabJenkins
Copy link

AmplabJenkins commented May 7, 2015

Merged build started.

@SparkQA
Copy link

SparkQA commented May 7, 2015

Test build #32113 has started for PR 5698 at commit d9a4439.

@SparkQA
Copy link

SparkQA commented May 7, 2015

Test build #32113 has finished for PR 5698 at commit d9a4439.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@AmplabJenkins
Copy link

AmplabJenkins commented May 7, 2015

Merged build finished. Test PASSed.

@AmplabJenkins
Copy link

AmplabJenkins commented May 7, 2015

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/32113/
Test PASSed.

@rxin
Copy link
Contributor

rxin commented May 7, 2015

Thanks. Merging this in master and branch-1.4.

asfgit pushed a commit that referenced this pull request May 7, 2015
@rxin
[SPARK-7118] [Python] Add the coalesce Spark SQL function available i…
3038b26 
…n PySpark

This patch adds a proxy call from PySpark to the Spark SQL coalesce function and this patch comes out of a discussion on devspark with rxin

This contribution is my original work and i license the work to the project under the project's open source license.

Olivier.

Author: Olivier Girardot <[email protected]>

Closes #5698 from ogirardot/master and squashes the following commits:

d9a4439 [Olivier Girardot] SPARK-7118 Add the coalesce Spark SQL function available in PySpark

(cherry picked from commit 068c315)
Signed-off-by: Reynold Xin <[email protected]>
@asfgit asfgit closed this in 068c315 May 7, 2015
jeanlyn pushed a commit to jeanlyn/spark that referenced this pull request May 28, 2015
@jeanlyn
[SPARK-7118] [Python] Add the coalesce Spark SQL function available i…
eab2714 
…n PySpark

This patch adds a proxy call from PySpark to the Spark SQL coalesce function and this patch comes out of a discussion on devspark with rxin

This contribution is my original work and i license the work to the project under the project's open source license.

Olivier.

Author: Olivier Girardot <[email protected]>

Closes apache#5698 from ogirardot/master and squashes the following commits:

d9a4439 [Olivier Girardot] SPARK-7118 Add the coalesce Spark SQL function available in PySpark
jeanlyn pushed a commit to jeanlyn/spark that referenced this pull request Jun 12, 2015
@jeanlyn
[SPARK-7118] [Python] Add the coalesce Spark SQL function available i…
e472173 
…n PySpark

This patch adds a proxy call from PySpark to the Spark SQL coalesce function and this patch comes out of a discussion on devspark with rxin

This contribution is my original work and i license the work to the project under the project's open source license.

Olivier.

Author: Olivier Girardot <[email protected]>

Closes apache#5698 from ogirardot/master and squashes the following commits:

d9a4439 [Olivier Girardot] SPARK-7118 Add the coalesce Spark SQL function available in PySpark
nemccarthy pushed a commit to nemccarthy/spark that referenced this pull request Jun 19, 2015
@nemccarthy
[SPARK-7118] [Python] Add the coalesce Spark SQL function available i…
015a1ce 
…n PySpark

This patch adds a proxy call from PySpark to the Spark SQL coalesce function and this patch comes out of a discussion on devspark with rxin

This contribution is my original work and i license the work to the project under the project's open source license.

Olivier.

Author: Olivier Girardot <[email protected]>

Closes apache#5698 from ogirardot/master and squashes the following commits:

d9a4439 [Olivier Girardot] SPARK-7118 Add the coalesce Spark SQL function available in PySpark
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@ogirardot @rxin @AmplabJenkins @SparkQA @pwendell