Skip to content

Conversation

@zsxwing
Copy link
Member

@zsxwing zsxwing commented Dec 22, 2014

Reuse Text in saveAsTextFile to reduce GC.

/cc @rxin

@zsxwing zsxwing changed the title Reuse Text in saveAsTextFile [SPARK-4918][Core] Reuse Text in saveAsTextFile Dec 22, 2014
@SparkQA
Copy link

SparkQA commented Dec 22, 2014

Test build #24704 has started for PR 3762 at commit 59f03eb.

  • This patch merges cleanly.

@srowen
Copy link
Member

srowen commented Dec 22, 2014

I think it's a small but OK optimization. Hadoop won't save the Text object itself, so it's safe, here in the 'save' method.

@SparkQA
Copy link

SparkQA commented Dec 22, 2014

Test build #24704 has finished for PR 3762 at commit 59f03eb.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@AmplabJenkins
Copy link

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/24704/
Test PASSed.

@sryza
Copy link
Contributor

sryza commented Dec 22, 2014

Great idea, LGTM

@rxin
Copy link
Contributor

rxin commented Dec 22, 2014

LGTM. Merging in master. Thanks.

@asfgit asfgit closed this in 93b2f3a Dec 22, 2014
@zsxwing zsxwing deleted the SPARK-4918 branch December 23, 2014 02:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants