Skip to content

SPARK-4805 [CORE] BlockTransferMessage.toByteArray() trips assertion #3650

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

SPARK-4805 [CORE] BlockTransferMessage.toByteArray() trips assertion #3650

wants to merge 1 commit into from

Conversation

@srowen
Copy link
Member

@srowen srowen commented Dec 9, 2014

Allocate enough room for type byte as well as message, to avoid tripping assertion about capacity of the buffer

@AmplabJenkins
Copy link

AmplabJenkins commented Dec 9, 2014

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/24264/
Test FAILed.

@aarondav
Copy link
Contributor

aarondav commented Dec 9, 2014

LGTM

@aarondav
Copy link
Contributor

aarondav commented Dec 9, 2014

Jenkins, retest this please.

@SparkQA
Copy link

SparkQA commented Dec 9, 2014

Test build #24266 has started for PR 3650 at commit 9e1d502.

  • This patch merges cleanly.

@SparkQA
Copy link

SparkQA commented Dec 10, 2014

Test build #24266 has finished for PR 3650 at commit 9e1d502.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@AmplabJenkins
Copy link

AmplabJenkins commented Dec 10, 2014

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/24266/
Test PASSed.

@aarondav
Copy link
Contributor

aarondav commented Dec 10, 2014

Merging into master and branch-1.2.

asfgit pushed a commit that referenced this pull request Dec 10, 2014
@srowen @aarondav
SPARK-4805 [CORE] BlockTransferMessage.toByteArray() trips assertion
b0d64e5 
Allocate enough room for type byte as well as message, to avoid tripping assertion about capacity of the buffer

Author: Sean Owen <[email protected]>

Closes #3650 from srowen/SPARK-4805 and squashes the following commits:

9e1d502 [Sean Owen] Allocate enough room for type byte as well as message, to avoid tripping assertion about capacity of the buffer

(cherry picked from commit d8f84f2)
Signed-off-by: Aaron Davidson <[email protected]>
@asfgit asfgit closed this in d8f84f2 Dec 10, 2014
@srowen srowen deleted the SPARK-4805 branch December 13, 2014 23:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@srowen @AmplabJenkins @aarondav @SparkQA