Skip to content

[SPARK-4663][sql]add finally to avoid resource leak #3526

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 3 commits into from
Closed

[SPARK-4663][sql]add finally to avoid resource leak #3526

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
ae0e447
add finally to avoid resource leak
baishuo Dec 1, 2014
b36bf96
correct the code style
baishuo Dec 1, 2014
d446e14
correct the code style
baishuo Dec 2, 2014
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 8 additions & 4 deletions sql/core/src/main/scala/org/apache/spark/sql/parquet/ParquetTableOperations.scala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -298,11 +298,15 @@ case class InsertIntoParquetTable(
val committer = format.getOutputCommitter(hadoopContext)
committer.setupTask(hadoopContext)
val writer = format.getRecordWriter(hadoopContext)
while (iter.hasNext) {
val row = iter.next()
writer.write(null, row)
try {
while (iter.hasNext) {
val row = iter.next()
writer.write(null, row)
}
}
finally {
Copy link
Contributor

@rxin rxin Dec 1, 2014

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can you put the finally on the same line as the previous } ? thanks.

writer.close(hadoopContext)
}
writer.close(hadoopContext)
committer.commitTask(hadoopContext)
return 1
}
Expand Down