[SPARK-37534][BUILD] Bump dev.ludovic.netlib to 2.2.1 #34783
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Can one of the admins verify this patch? |
2.2.1 fixes a bug in sgemm
Member
dongjoon-hyun
left a comment
dongjoon-hyun
left a comment
There was a problem hiding this comment.
Thank you for making a PR, @luhenry .
Do you think you can file an Apache Spark JIRA issue for this and use the JIRA ID prefix in your PR title?
luhenry
changed the title
Contributor
Author
|
@dongjoon-hyun I created the issue at https://issues.apache.org/jira/browse/SPARK-37534 and linked it in the title. |
Member
|
Thank you, @luhenry . |
dongjoon-hyun
changed the title
dongjoon-hyun
approved these changes
Dec 3, 2021
Member
dongjoon-hyun
left a comment
dongjoon-hyun
left a comment
There was a problem hiding this comment.
+1, LGTM. Merged to master.
Member
|
According to the context, I switched your JIRA type from |
Contributor
Author
|
@dongjoon-hyun thank you for merging! I submitted #34797 for 3.2 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Bump the version of dev.ludovic.netlib from 2.2.0 to 2.2.1. This fixes a computation bug in sgemm. See [1]. Diff is [2]
[1] luhenry/netlib#7
[2] luhenry/netlib@v2.2.0...v2.2.1
Why are the changes needed?
Does this PR introduce any user-facing change?
How was this patch tested?