Skip to content

[SPARK-4597] Use proper exception and reset variable #3449

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

[SPARK-4597] Use proper exception and reset variable #3449

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion core/src/main/scala/org/apache/spark/util/Utils.scala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -262,7 +262,7 @@ private[spark] object Utils extends Logging {
if (dir.exists() || !dir.mkdirs()) {
dir = null
}
} catch { case e: IOException => ; }
} catch { case e: SecurityException => dir = null; }
Copy link
Member

@srowen srowen Nov 25, 2014

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks like these two methods can't throw IOException after all, is that the gist of it? mkdirs just returns false if it fails, hm. https://docs.oracle.com/javase/7/docs/api/java/io/File.html#mkdirs()

dir = null is a good bug fix. I might have changed this to not even assign dir and hold the new File in a temp variable until the checks succeeded. This looks equivalent though.

Copy link
Member Author

@viirya viirya Nov 25, 2014

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes. The only exception they would throw is SecurityException. And when mkdirs finds failures other than SecurityException it just returns false.

}

registerShutdownDeleteDir(dir)
Expand Down