[SPARK-4597] Use proper exception and reset variable #3449
Conversation
|
Jenkins, this is ok to test. |
There was a problem hiding this comment.
It looks like these two methods can't throw IOException after all, is that the gist of it? mkdirs just returns false if it fails, hm. https://docs.oracle.com/javase/7/docs/api/java/io/File.html#mkdirs()
dir = null is a good bug fix. I might have changed this to not even assign dir and hold the new File in a temp variable until the checks succeeded. This looks equivalent though.
There was a problem hiding this comment.
Yes. The only exception they would throw is SecurityException. And when mkdirs finds failures other than SecurityException it just returns false.
|
Test build #23831 has finished for PR 3449 at commit
|
|
@JoshRosen @srowen Any other comments? Is this ok to be merged? |
|
LGTM, so I'm going to merge this into |
…empDir() `File.exists()` and `File.mkdirs()` only throw `SecurityException` instead of `IOException`. Then, when an exception is thrown, `dir` should be reset too. Author: Liang-Chi Hsieh <[email protected]> Closes #3449 from viirya/fix_createtempdir and squashes the following commits: 36cacbd [Liang-Chi Hsieh] Use proper exception and reset variable. (cherry picked from commit 49fe879) Signed-off-by: Josh Rosen <[email protected]>
…empDir() `File.exists()` and `File.mkdirs()` only throw `SecurityException` instead of `IOException`. Then, when an exception is thrown, `dir` should be reset too. Author: Liang-Chi Hsieh <[email protected]> Closes #3449 from viirya/fix_createtempdir and squashes the following commits: 36cacbd [Liang-Chi Hsieh] Use proper exception and reset variable. (cherry picked from commit 49fe879) Signed-off-by: Josh Rosen <[email protected]>
…empDir() `File.exists()` and `File.mkdirs()` only throw `SecurityException` instead of `IOException`. Then, when an exception is thrown, `dir` should be reset too. Author: Liang-Chi Hsieh <[email protected]> Closes #3449 from viirya/fix_createtempdir and squashes the following commits: 36cacbd [Liang-Chi Hsieh] Use proper exception and reset variable. (cherry picked from commit 49fe879) Signed-off-by: Josh Rosen <[email protected]>
4 participants
File.exists()andFile.mkdirs()only throwSecurityExceptioninstead ofIOException. Then, when an exception is thrown,dirshould be reset too.