-
Notifications
You must be signed in to change notification settings - Fork 28.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[SPARK-35930][BUILD] Upgrade kinesis-client to 1.14.4 #33133
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for making a PR, @sarutak . BTW, is it tested manually because this is not covered by CIs?
@dongjoon-hyun Thank you, I forgot that kinesis tests don't run on CI.
So, I tried with I also ran kinesis tests on the commit a9e8e05 which upgraded kinesis-client to |
Test build #140357 has finished for PR 33133 at commit
|
Since there are some previous works to address the Guava restriction, ping @viirya , @sunchao , @HyukjinKwon in order to get some advice. |
Yeah, a9e8e05 was not merged to |
Does it mean we'd need to upgrade Guava version in order for kinesis-client to work in Spark 3.2.0? |
FYI, I re-opened #29326 to try upgrading guava again. |
Shall we revert a9e8e05 first? |
…dk 1.11.844" ### What changes were proposed in this pull request? This PR reverts the change of SPARK-34549 ( #31658). ### Why are the changes needed? See #33133. ### Does this PR introduce _any_ user-facing change? No. ### How was this patch tested? Closes #33145 from sarutak/revert-SPARK-34549. Authored-by: Kousuke Saruta <[email protected]> Signed-off-by: Hyukjin Kwon <[email protected]>
Since SPARK-34549 is reverted, I'll close this PR, @sarutak . Thank you for checking. After Guava issue is resolved, feel free to reopen this. |
What changes were proposed in this pull request?
This PR upgrades kinesis-client from 1.14.0 to 1.14.4
Why are the changes needed?
Upgrading to 1.14.1 or newer is recommended by the community for users who use kinesis-client 1.14.0 due to a bug.
https://github.com/awslabs/amazon-kinesis-client/tree/master#recommended-upgrade-for-all-users-of-the-1x-amazon-kinesis-client
Does this PR introduce any user-facing change?
No.
How was this patch tested?
Ran
*Kinesis*Suite
withENABLE_KINESIS_TESTS=1
and they passed on an AWS environment