Skip to content

Internal cleanup for aggregateMessages #3231

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

Internal cleanup for aggregateMessages #3231

wants to merge 1 commit into from

Conversation

@ankurdave
Copy link
Contributor

@ankurdave ankurdave commented Nov 12, 2014

  1. Add EdgeActiveness enum to represent activeness criteria more cleanly than using booleans.
  2. Comments and whitespace.

@ankurdave
Internal cleanup for aggregateMessages
3d485c3 
1. Add EdgeActiveness enum to represent activeness criteria more cleanly
than using booleans.
2. Comments and whitespace.
@SparkQA
Copy link

SparkQA commented Nov 12, 2014

Test build #23273 has started for PR 3231 at commit 3d485c3.

  • This patch merges cleanly.

@SparkQA
Copy link

SparkQA commented Nov 12, 2014

Test build #23273 has finished for PR 3231 at commit 3d485c3.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@AmplabJenkins
Copy link

AmplabJenkins commented Nov 12, 2014

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/23273/
Test PASSed.

@ankurdave
Copy link
Contributor Author

ankurdave commented Nov 12, 2014

@rxin

@rxin
Copy link
Contributor

rxin commented Nov 12, 2014

Thanks - merging in master & branch-1.2.

@asfgit asfgit closed this in 0402be9 Nov 12, 2014
asfgit pushed a commit that referenced this pull request Nov 12, 2014
@ankurdave @rxin
Internal cleanup for aggregateMessages
5d5c8fd 
1. Add EdgeActiveness enum to represent activeness criteria more cleanly than using booleans.
2. Comments and whitespace.

Author: Ankur Dave <[email protected]>

Closes #3231 from ankurdave/aggregateMessages-followup and squashes the following commits:

3d485c3 [Ankur Dave] Internal cleanup for aggregateMessages

(cherry picked from commit 0402be9)
Signed-off-by: Reynold Xin <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@ankurdave @SparkQA @AmplabJenkins @rxin