Skip to content

Conversation

@pwendell
Copy link
Contributor

This is currently breaking the package build for some people (including me).

This patch does some general clean-up which also fixes the current issue.

  • Uses consistent artifact naming
  • Adds sbt support for this module
  • Changes tests to use scalatest (fixes the original issue[1])

One thing to note, it turns out that scalatest when invoked in the
Maven build doesn't succesfully detect JUnit Java tests. This is
a long standing issue, I noticed it applies to all of our current
test suites as well. I've created SPARK-4159 to fix this.

[1] The original issue is that we need to allocate extra memory
for the tests, happens by default in our scalatest configuration.

@SparkQA
Copy link

SparkQA commented Oct 30, 2014

Test build #22568 has started for PR 3025 at commit af2b785.

  • This patch merges cleanly.

@aarondav
Copy link
Contributor

LGTM!

@SparkQA
Copy link

SparkQA commented Oct 30, 2014

Test build #22568 has finished for PR 3025 at commit af2b785.

  • This patch fails MiMa tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@AmplabJenkins
Copy link

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/22568/
Test FAILed.

@pwendell
Copy link
Contributor Author

@aarondav I didn't try MIMA with this new thing. I'll get it working and resubmit.

This does a few things
- Uses consistent artifact naming
- Changes this to use scalatest
- Adds this to sbt

One thing to note, it turns out that scalatest when invoked in the
Maven build doesn't succesfully detect JUnit Java tests. This is
a long standing issue, I noticed it applies to all of our current
test suites as well. I've created SPARK-4159 to fix this.
@pwendell
Copy link
Contributor Author

Jenkins, test this please.

@SparkQA
Copy link

SparkQA commented Oct 31, 2014

Test build #22586 has started for PR 3025 at commit faa9053.

  • This patch merges cleanly.

@SparkQA
Copy link

SparkQA commented Oct 31, 2014

Test build #22586 has finished for PR 3025 at commit faa9053.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@AmplabJenkins
Copy link

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/22586/
Test PASSed.

@aarondav
Copy link
Contributor

Merging into master, thanks!

@asfgit asfgit closed this in 0734d09 Oct 31, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants