Skip to content

[SPARK-3954][Streaming] Optimization to FileInputDStream #2811

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 5 commits into from
Closed

[SPARK-3954][Streaming] Optimization to FileInputDStream #2811

Changes from 1 commit
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
739341f
promote the speed of convert files to RDDS
surongquan Oct 15, 2014
626ef97
remove redundant import(ArrayBuffer)
surongquan Oct 15, 2014
178066f
modify code's style. [Exceeds 100 columns]
surongquan Nov 3, 2014
88a2c20
Merge branch 'master' of https://github.com/apache/spark into SPARK-3954
surongquan Nov 3, 2014
321bbe8
surongquan Nov 10, 2014
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 4 additions & 3 deletions streaming/src/main/scala/org/apache/spark/streaming/dstream/FileInputDStream.scala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,6 +27,7 @@ import org.apache.spark.rdd.RDD
import org.apache.spark.rdd.UnionRDD
import org.apache.spark.streaming.{StreamingContext, Time}
import org.apache.spark.util.TimeStampedHashMap
import scala.collection.mutable.ArrayBuffer
Copy link
Contributor

@jerryshao jerryshao Oct 15, 2014

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does your modification use ArrayBuffer, seems it is not used.



private[streaming]
Expand Down Expand Up @@ -120,14 +121,14 @@ class FileInputDStream[K: ClassTag, V: ClassTag, F <: NewInputFormat[K,V] : Clas

/** Generate one RDD from an array of files */
private def filesToRDD(files: Seq[String]): RDD[(K, V)] = {
val fileRDDs = files.map(file => context.sparkContext.newAPIHadoopFile[K, V, F](file))
files.zip(fileRDDs).foreach { case (file, rdd) => {
val fileRDDs = for (file <- files; rdd = context.sparkContext.newAPIHadoopFile[K, V, F](file)) yield {
Copy link
Contributor

@liancheng liancheng Nov 2, 2014

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Exceeds 100 columns.

if (rdd.partitions.size == 0) {
logError("File " + file + " has no data in it. Spark Streaming can only ingest " +
"files that have been \"moved\" to the directory assigned to the file stream. " +
"Refer to the streaming programming guide for more details.")
}
}}
rdd
}
new UnionRDD(context.sparkContext, fileRDDs)
}

Expand Down