From b4d56b20f9b83edea918914221c35b32805495b5 Mon Sep 17 00:00:00 2001
From: HyukjinKwon <gurwls223@apache.org>
Date: Wed, 31 Jul 2019 15:24:32 +0900
Subject: [PATCH 1/5] Improve Github pull request template

---
 .github/PULL_REQUEST_TEMPLATE | 41 ++++++++++++++++++++++++++++++-----
 1 file changed, 35 insertions(+), 6 deletions(-)

diff --git a/.github/PULL_REQUEST_TEMPLATE b/.github/PULL_REQUEST_TEMPLATE
index e7ed23dea0f9..efa21091ea5a 100644
--- a/.github/PULL_REQUEST_TEMPLATE
+++ b/.github/PULL_REQUEST_TEMPLATE
@@ -1,10 +1,39 @@
-## What changes were proposed in this pull request?
+<!--
+Thanks for sending a pull request!  Here are some tips for you:
+  1. If this is your first time, please read our contributor guidelines: https://spark.apache.org/contributing.html
+  2. Ensure you have added or run the appropriate tests for your PR: https://spark.apache.org/developer-tools.html
+  3. If the PR is unfinished, add '[WIP]' in your PR title, e.g., '[WIP][SPARK-XXXX] Your PR title ...'.
+  4. Update your PR description whenever it is needed.
+  5. Provide a concise example to reproduce the issue if possible for a faster review.
+-->
 
-(Please fill in changes proposed in this fix)
+### What changes were proposed in this pull request?
+<!--
+Please clarify what changes you are proposing. The purpose of this section is to outline the changes and how this PR fixes the issue. 
+Therefore, if possible, please consider write some useful notes for better and faster reviews in your PR. See the examples below.
+  1. If you refactor some codes with changing classes, showing the class hierarchy will help reviewers.
+  2. If you fix some SQL features, you can provide some references of other DBMSes.
+  3. If there is a design documentation, please leave the link.
+  4. If there is a discussion in the mailing list, please leave the link.
+-->
 
-## How was this patch tested?
 
-(Please explain how this patch was tested. E.g. unit tests, integration tests, manual tests)
-(If this patch involves UI changes, please attach a screenshot; otherwise, remove this)
+### Why are the changes needed?
+<!--
+Please clarify why the changes are needed. For instance,
+  1. If you propose a new API, clarify the usecase for a new API.
+  2. If you fixes a bug, you can calrify why it is a bug.
+-->
 
-Please review https://spark.apache.org/contributing.html before opening a pull request.
+### Does this PR introduce any user-facing change?
+<!--
+If yes, please clarify the previous behavior and the change this PR proposes - provide the console output, description and/or an example to show the behaviour difference if possible.
+If no, write 'No'.
+-->
+
+
+### How was this patch tested?
+<!--
+If some tests were added, say they were added here. Please make sure to add some test cases that check the changes thoroughly including negative and positive cases if possible.
+If it was tested in a way different from regular unit tests, please clarify how you tested step by step, ideally copy and paste-able, so that other reviewers can test and check through, and descendants can verify in the future.
+-->

From d1298efcdfbef4f19ec0670da5bd0b4b6ba83891 Mon Sep 17 00:00:00 2001
From: Hyukjin Kwon <gurwls223@apache.org>
Date: Mon, 5 Aug 2019 00:25:32 +0900
Subject: [PATCH 2/5] Update .github/PULL_REQUEST_TEMPLATE

Co-Authored-By: Marco Gaido <marcogaido91@gmail.com>
---
 .github/PULL_REQUEST_TEMPLATE | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/.github/PULL_REQUEST_TEMPLATE b/.github/PULL_REQUEST_TEMPLATE
index efa21091ea5a..b54e337280ba 100644
--- a/.github/PULL_REQUEST_TEMPLATE
+++ b/.github/PULL_REQUEST_TEMPLATE
@@ -21,7 +21,7 @@ Therefore, if possible, please consider write some useful notes for better and f
 ### Why are the changes needed?
 <!--
 Please clarify why the changes are needed. For instance,
-  1. If you propose a new API, clarify the usecase for a new API.
+  1. If you propose a new API, clarify the use case for a new API.
   2. If you fixes a bug, you can calrify why it is a bug.
 -->
 

From 30eef76071ac5ccd0534a138865f1b3652c04d58 Mon Sep 17 00:00:00 2001
From: HyukjinKwon <gurwls223@apache.org>
Date: Mon, 5 Aug 2019 00:28:39 +0900
Subject: [PATCH 3/5] Address comments

---
 .github/PULL_REQUEST_TEMPLATE | 1 +
 1 file changed, 1 insertion(+)

diff --git a/.github/PULL_REQUEST_TEMPLATE b/.github/PULL_REQUEST_TEMPLATE
index b54e337280ba..d623b5f5334a 100644
--- a/.github/PULL_REQUEST_TEMPLATE
+++ b/.github/PULL_REQUEST_TEMPLATE
@@ -36,4 +36,5 @@ If no, write 'No'.
 <!--
 If some tests were added, say they were added here. Please make sure to add some test cases that check the changes thoroughly including negative and positive cases if possible.
 If it was tested in a way different from regular unit tests, please clarify how you tested step by step, ideally copy and paste-able, so that other reviewers can test and check through, and descendants can verify in the future.
+If tests were not added, please describe why they were not added and/or why it was difficult to add.
 -->

From 30de1a053d514f04793928661b35440de28d122a Mon Sep 17 00:00:00 2001
From: HyukjinKwon <gurwls223@apache.org>
Date: Tue, 13 Aug 2019 15:34:40 +0900
Subject: [PATCH 4/5] Address comments

---
 .github/PULL_REQUEST_TEMPLATE | 19 ++++++++++---------
 1 file changed, 10 insertions(+), 9 deletions(-)

diff --git a/.github/PULL_REQUEST_TEMPLATE b/.github/PULL_REQUEST_TEMPLATE
index d623b5f5334a..daed6a6e23a3 100644
--- a/.github/PULL_REQUEST_TEMPLATE
+++ b/.github/PULL_REQUEST_TEMPLATE
@@ -3,18 +3,19 @@ Thanks for sending a pull request!  Here are some tips for you:
   1. If this is your first time, please read our contributor guidelines: https://spark.apache.org/contributing.html
   2. Ensure you have added or run the appropriate tests for your PR: https://spark.apache.org/developer-tools.html
   3. If the PR is unfinished, add '[WIP]' in your PR title, e.g., '[WIP][SPARK-XXXX] Your PR title ...'.
-  4. Update your PR description whenever it is needed.
-  5. Provide a concise example to reproduce the issue if possible for a faster review.
+  4. Be sure to keep the PR description updated to reflect all changes.
+  5. Please write your PR title to summarize what this PR proposes.
+  6. If possible, provide a concise example to reproduce the issue for a faster review.
 -->
 
 ### What changes were proposed in this pull request?
 <!--
 Please clarify what changes you are proposing. The purpose of this section is to outline the changes and how this PR fixes the issue. 
-Therefore, if possible, please consider write some useful notes for better and faster reviews in your PR. See the examples below.
+If possible, please consider writing useful notes for better and faster reviews in your PR. See the examples below.
   1. If you refactor some codes with changing classes, showing the class hierarchy will help reviewers.
   2. If you fix some SQL features, you can provide some references of other DBMSes.
-  3. If there is a design documentation, please leave the link.
-  4. If there is a discussion in the mailing list, please leave the link.
+  3. If there is design documentation, please add the link.
+  4. If there is a discussion in the mailing list, please add the link.
 -->
 
 
@@ -22,19 +23,19 @@ Therefore, if possible, please consider write some useful notes for better and f
 <!--
 Please clarify why the changes are needed. For instance,
   1. If you propose a new API, clarify the use case for a new API.
-  2. If you fixes a bug, you can calrify why it is a bug.
+  2. If you fix a bug, you can clarify why it is a bug.
 -->
 
 ### Does this PR introduce any user-facing change?
 <!--
-If yes, please clarify the previous behavior and the change this PR proposes - provide the console output, description and/or an example to show the behaviour difference if possible.
+If yes, please clarify the previous behavior and the change this PR proposes - provide the console output, description and/or an example to show the behavior difference if possible.
 If no, write 'No'.
 -->
 
 
 ### How was this patch tested?
 <!--
-If some tests were added, say they were added here. Please make sure to add some test cases that check the changes thoroughly including negative and positive cases if possible.
-If it was tested in a way different from regular unit tests, please clarify how you tested step by step, ideally copy and paste-able, so that other reviewers can test and check through, and descendants can verify in the future.
+If tests were added, say they were added here. Please make sure to add some test cases that check the changes thoroughly including negative and positive cases if possible.
+If it was tested in a way different from regular unit tests, please clarify how you tested step by step, ideally copy and paste-able, so that other reviewers can test and check, and descendants can verify in the future.
 If tests were not added, please describe why they were not added and/or why it was difficult to add.
 -->

From 5ac58c9fd5f6966dfaf3f688fa3102c1952d8493 Mon Sep 17 00:00:00 2001
From: HyukjinKwon <gurwls223@apache.org>
Date: Tue, 13 Aug 2019 15:39:06 +0900
Subject: [PATCH 5/5] Spacing

---
 .github/PULL_REQUEST_TEMPLATE | 1 +
 1 file changed, 1 insertion(+)

diff --git a/.github/PULL_REQUEST_TEMPLATE b/.github/PULL_REQUEST_TEMPLATE
index daed6a6e23a3..be57f007abbf 100644
--- a/.github/PULL_REQUEST_TEMPLATE
+++ b/.github/PULL_REQUEST_TEMPLATE
@@ -26,6 +26,7 @@ Please clarify why the changes are needed. For instance,
   2. If you fix a bug, you can clarify why it is a bug.
 -->
 
+
 ### Does this PR introduce any user-facing change?
 <!--
 If yes, please clarify the previous behavior and the change this PR proposes - provide the console output, description and/or an example to show the behavior difference if possible.