From c7b4c46425811ce68003dcf851a7d1867973ddf3 Mon Sep 17 00:00:00 2001
From: Vinod KC <vinod.kc.in@gmail.com>
Date: Wed, 10 Jul 2019 08:22:51 +0530
Subject: [PATCH 1/2] 
 sql/core/src/test/resources/sql-tests/inputs/udf/udf-count.sql

---
 .../sql-tests/inputs/udf/udf-count.sql        | 28 +++++++++++++++++++
 1 file changed, 28 insertions(+)
 create mode 100644 sql/core/src/test/resources/sql-tests/inputs/udf/udf-count.sql

diff --git a/sql/core/src/test/resources/sql-tests/inputs/udf/udf-count.sql b/sql/core/src/test/resources/sql-tests/inputs/udf/udf-count.sql
new file mode 100644
index 000000000000..6ab207b93f56
--- /dev/null
+++ b/sql/core/src/test/resources/sql-tests/inputs/udf/udf-count.sql
@@ -0,0 +1,28 @@
+-- This test file was converted from count.sql
+-- Test data.
+CREATE OR REPLACE TEMPORARY VIEW testData AS SELECT * FROM VALUES
+(1, 1), (1, 2), (2, 1), (1, 1), (null, 2), (1, null), (null, null)
+AS testData(a, b);
+
+-- count with single expression
+SELECT
+  udf(count(*)), udf(count(1)), udf(count(null)), udf(count(a)), udf(count(b)), udf(count(a + b)), udf(count((a, b)))
+FROM testData;
+
+-- distinct count with single expression
+SELECT
+  udf(count(DISTINCT 1)),
+  udf(count(DISTINCT null)),
+  udf(count(DISTINCT a)),
+  udf(count(DISTINCT b)),
+  udf(count(DISTINCT (a + b))),
+  udf(count(DISTINCT (a, b)))
+FROM testData;
+
+-- count with multiple expressions
+SELECT udf(count(a, b)), udf(count(b, a)), udf(count(testData.*)) FROM testData;
+
+-- distinct count with multiple expressions
+SELECT
+  udf(count(DISTINCT a, b)), udf(count(DISTINCT b, a)), udf(count(DISTINCT *)), udf(count(DISTINCT testData.*))
+FROM testData;

From b173330d416f54c30d327228c21965d3c4457722 Mon Sep 17 00:00:00 2001
From: Vinod KC <vinod.kc.in@gmail.com>
Date: Wed, 10 Jul 2019 09:03:49 +0530
Subject: [PATCH 2/2] added udf-count.sql.out

---
 .../sql-tests/results/udf/udf-count.sql.out   | 55 +++++++++++++++++++
 1 file changed, 55 insertions(+)
 create mode 100644 sql/core/src/test/resources/sql-tests/results/udf/udf-count.sql.out

diff --git a/sql/core/src/test/resources/sql-tests/results/udf/udf-count.sql.out b/sql/core/src/test/resources/sql-tests/results/udf/udf-count.sql.out
new file mode 100644
index 000000000000..9476937abd9e
--- /dev/null
+++ b/sql/core/src/test/resources/sql-tests/results/udf/udf-count.sql.out
@@ -0,0 +1,55 @@
+-- Automatically generated by SQLQueryTestSuite
+-- Number of queries: 5
+
+
+-- !query 0
+CREATE OR REPLACE TEMPORARY VIEW testData AS SELECT * FROM VALUES
+(1, 1), (1, 2), (2, 1), (1, 1), (null, 2), (1, null), (null, null)
+AS testData(a, b)
+-- !query 0 schema
+struct<>
+-- !query 0 output
+
+
+
+-- !query 1
+SELECT
+  udf(count(*)), udf(count(1)), udf(count(null)), udf(count(a)), udf(count(b)), udf(count(a + b)), udf(count((a, b)))
+FROM testData
+-- !query 1 schema
+struct<udf(count(1)):string,udf(count(1)):string,udf(count(null)):string,udf(count(a)):string,udf(count(b)):string,udf(count((a + b))):string,udf(count(named_struct(a, a, b, b))):string>
+-- !query 1 output
+7	7	0	5	5	4	7
+
+
+-- !query 2
+SELECT
+  udf(count(DISTINCT 1)),
+  udf(count(DISTINCT null)),
+  udf(count(DISTINCT a)),
+  udf(count(DISTINCT b)),
+  udf(count(DISTINCT (a + b))),
+  udf(count(DISTINCT (a, b)))
+FROM testData
+-- !query 2 schema
+struct<udf(count(distinct 1)):string,udf(count(distinct null)):string,udf(count(distinct a)):string,udf(count(distinct b)):string,udf(count(distinct (a + b))):string,udf(count(distinct named_struct(a, a, b, b))):string>
+-- !query 2 output
+1	0	2	2	2	6
+
+
+-- !query 3
+SELECT udf(count(a, b)), udf(count(b, a)), udf(count(testData.*)) FROM testData
+-- !query 3 schema
+struct<udf(count(a, b)):string,udf(count(b, a)):string,udf(count(a, b)):string>
+-- !query 3 output
+4	4	4
+
+
+-- !query 4
+SELECT
+  udf(count(DISTINCT a, b)), udf(count(DISTINCT b, a)), udf(count(DISTINCT *)), udf(count(DISTINCT testData.*))
+FROM testData
+-- !query 4 schema
+struct<udf(count(distinct a, b)):string,udf(count(distinct b, a)):string,udf(count(distinct a, b)):string,udf(count(distinct a, b)):string>
+-- !query 4 output
+3	3	3	3