Skip to content

[SQL] [Docs] typo fixes #2367

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 2 commits into from
Closed

[SQL] [Docs] typo fixes #2367

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
3247ac1
[SQL] [Docs] typo fixes
nchammas Sep 12, 2014
aa528be
doc fix for SQL DecimalType
nchammas Sep 12, 2014
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 1 addition & 2 deletions docs/sql-programming-guide.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -918,7 +918,6 @@ options.
## Migration Guide for Shark User

### Scheduling
s
To set a [Fair Scheduler](job-scheduling.html#fair-scheduler-pools) pool for a JDBC client session,
users can set the `spark.sql.thriftserver.scheduler.pool` variable:

Expand Down Expand Up @@ -1110,7 +1109,7 @@ evaluated by the SQL execution engine. A full list of the functions supported c
The range of numbers is from `-9223372036854775808` to `9223372036854775807`.
- `FloatType`: Represents 4-byte single-precision floating point numbers.
- `DoubleType`: Represents 8-byte double-precision floating point numbers.
- `DecimalType`:
- `DecimalType`: Represents 16-byte arbitrary-precision floating point numbers.
Copy link
Contributor Author

@nchammas nchammas Sep 12, 2014

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not 100% sure about this, actually, but the description is obviously missing.

Copy link
Contributor

@marmbrus marmbrus Sep 12, 2014

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Represents arbitrary-precision signed decimal numbers. A BigDecimal consists of an arbitrary precision integer unscaled value and a 32-bit integer scale. Backed internally by java.math.BigDecimal.

Copy link
Contributor Author

@nchammas nchammas Sep 12, 2014

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Did you mean "A DecimalType consists of..."?

Copy link
Contributor Author

@nchammas nchammas Sep 12, 2014

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Or perhaps a reordering of the sentences as such?

Represents arbitrary-precision signed decimal numbers. Backed internally by java.math.BigDecimal. A BigDecimal consists of an arbitrary precision integer unscaled value and a 32-bit integer scale.

Copy link
Contributor

@marmbrus marmbrus Sep 12, 2014

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sure, either way.

Copy link
Contributor Author

@nchammas nchammas Sep 12, 2014

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Okie doke. Done. (the latter way)

* String type
- `StringType`: Represents character string values.
* Binary type
Expand Down