[SPARK-25286][CORE] Removing the dangerous parmap #22292
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit 72cdfeb.
Member
Author
|
@zsxwing @gatorsmile Please, have a look at the PR. |
zsxwing
reviewed
Aug 30, 2018
| handler: I => Iterator[O]): Iterator[O] = { | ||
| val taskSupport = new ExecutionContextTaskSupport(executionContext) | ||
| val groupSize = taskSupport.parallelismLevel.max(8) | ||
| implicit val ec = executionContext |
|
Test build #95492 has finished for PR 22292 at commit
|
Member
|
For future, let us keep a connection with #22233 that is the original one |
|
Test build #95526 has finished for PR 22292 at commit
|
Member
Author
|
jenkins, retest this, please |
|
Test build #95531 has finished for PR 22292 at commit
|
Member
|
Thanks! Merged to master. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
I propose to remove one of
parmapmethods which accepts an execution context as a parameter. The method should be removed to eliminate any deadlocks that can occur ifparmapis called recursively on thread pools restricted by size.