[SPARK-24951][SQL] Table valued functions should throw AnalysisException #21934
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@rxin, thanks! I am a bot who has found some folks who might be able to help with the review:@hvanhovell, @cloud-fan and @gatorsmile |
Contributor
Author
|
cc @gatorsmile @ericl who originally wrote this. |
Contributor
|
LGTM |
|
Test build #93834 has finished for PR 21934 at commit
|
Contributor
Author
|
Jenkins, retest this please. |
dilipbiswal
reviewed
Jul 31, 2018
| java.lang.IllegalArgumentException | ||
| Invalid arguments for resolved function: 1, null | ||
| org.apache.spark.sql.AnalysisException | ||
| error: table-valued function range with alternatives: |
Contributor
There was a problem hiding this comment.
Nit: @rxin will it be better to display the function name within single quotes ?
Contributor
Author
There was a problem hiding this comment.
probably could go either way
Member
|
retest this please |
|
Test build #93849 has finished for PR 21934 at commit
|
gatorsmile
reviewed
Aug 1, 2018
Member
gatorsmile
left a comment
gatorsmile
left a comment
There was a problem hiding this comment.
LGTM
Thanks! Merged to master.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Previously TVF resolution could throw IllegalArgumentException if the data type is null type. This patch replaces that exception with AnalysisException, enriched with positional information, to improve error message reporting and to be more consistent with rest of Spark SQL.
How was this patch tested?
Updated the test case in table-valued-functions.sql.out, which is how I identified this problem in the first place.