-
Notifications
You must be signed in to change notification settings - Fork 29k
[SPARK-3273][SPARK-3301]We should read the version information from the same place #2175
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
QA tests have started for PR 2175 at commit
|
|
QA tests have finished for PR 2175 at commit
|
|
Jenkins, retest this please. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we get this from SparkContext ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is a good idea.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
glad to see this change!
|
Do we need to make any matching changes to the PySpark shell as part of this PR? As an aside, SPARK-2697 is a related JIRA issue that captures the need to source this shell banner from a single place. Right now shell banner versions have to be updated in 2 places. |
|
@nchammas We should create a separate jira for the python-related issues |
|
Jenkins, retest this please. |
|
QA tests have started for PR 2175 at commit
|
|
QA tests have finished for PR 2175 at commit
|
|
QA tests have started for PR 2175 at commit
|
|
QA tests have finished for PR 2175 at commit
|
|
QA tests have started for PR 2175 at commit
|
|
QA tests have finished for PR 2175 at commit
|
|
This looks good to me. There are a bunch of outdated versions in the pom files that should be bumped to 1.2.0-SNAPSHOT, but we can do that as part of a separate hotfix commit. |
|
QA tests have started for PR 2175 at commit
|
|
QA tests have finished for PR 2175 at commit
|
|
Since I just merged the other PR that bumps the version to 1.2.0-SNAPSHOT, I'm going to merge this too. Thanks! |
No description provided.