Skip to content

Conversation

@witgo
Copy link
Contributor

@witgo witgo commented Aug 28, 2014

No description provided.

@SparkQA
Copy link

SparkQA commented Aug 28, 2014

QA tests have started for PR 2175 at commit 3873f4c.

  • This patch merges cleanly.

@SparkQA
Copy link

SparkQA commented Aug 28, 2014

QA tests have finished for PR 2175 at commit 3873f4c.

  • This patch fails unit tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@pwendell
Copy link
Contributor

Jenkins, retest this please.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we get this from SparkContext ?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a good idea.

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

glad to see this change!

@nchammas
Copy link
Contributor

Do we need to make any matching changes to the PySpark shell as part of this PR?

As an aside, SPARK-2697 is a related JIRA issue that captures the need to source this shell banner from a single place. Right now shell banner versions have to be updated in 2 places.

@witgo
Copy link
Contributor Author

witgo commented Aug 29, 2014

@nchammas We should create a separate jira for the python-related issues

@witgo
Copy link
Contributor Author

witgo commented Aug 29, 2014

Jenkins, retest this please.

@SparkQA
Copy link

SparkQA commented Aug 29, 2014

QA tests have started for PR 2175 at commit 5cbbf7d.

  • This patch merges cleanly.

@SparkQA
Copy link

SparkQA commented Aug 29, 2014

QA tests have finished for PR 2175 at commit 5cbbf7d.

  • This patch passes unit tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@witgo witgo changed the title [SPARK-3273]The spark version in the welcome message of spark-shell is not correct [SPARK-3273][SPARK-3302]We should read the version information from the same place Aug 29, 2014
@SparkQA
Copy link

SparkQA commented Aug 29, 2014

QA tests have started for PR 2175 at commit 82a8327.

  • This patch merges cleanly.

@SparkQA
Copy link

SparkQA commented Aug 29, 2014

QA tests have finished for PR 2175 at commit 82a8327.

  • This patch passes unit tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@witgo witgo changed the title [SPARK-3273][SPARK-3302]We should read the version information from the same place [SPARK-3273][SPARK-3302][SPARK-3301]We should read the version information from the same place Sep 3, 2014
@SparkQA
Copy link

SparkQA commented Sep 3, 2014

QA tests have started for PR 2175 at commit 2aa2a9f.

  • This patch merges cleanly.

@SparkQA
Copy link

SparkQA commented Sep 3, 2014

QA tests have finished for PR 2175 at commit 2aa2a9f.

  • This patch passes unit tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@witgo witgo changed the title [SPARK-3273][SPARK-3302][SPARK-3301]We should read the version information from the same place [SPARK-3273][SPARK-3301]We should read the version information from the same place Sep 4, 2014
@JoshRosen
Copy link
Contributor

This looks good to me. There are a bunch of outdated versions in the pom files that should be bumped to 1.2.0-SNAPSHOT, but we can do that as part of a separate hotfix commit.

@SparkQA
Copy link

SparkQA commented Sep 5, 2014

QA tests have started for PR 2175 at commit cf9c65a.

  • This patch merges cleanly.

@SparkQA
Copy link

SparkQA commented Sep 6, 2014

QA tests have finished for PR 2175 at commit cf9c65a.

  • This patch passes unit tests.
  • This patch merges cleanly.
  • This patch adds the following public classes (experimental):
    • case class AddJar(path: String) extends LeafNode with Command

@JoshRosen
Copy link
Contributor

Since I just merged the other PR that bumps the version to 1.2.0-SNAPSHOT, I'm going to merge this too. Thanks!

@asfgit asfgit closed this in 21a1e1b Sep 6, 2014
@witgo witgo deleted the SPARK-3273 branch September 7, 2014 02:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants