[SPARK-24688][examples]Modify the comments about LabeledPoint #21665
+4
−4
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Author
|
ok to test |
1 similar comment
Author
|
ok to test |
srowen
requested changes
Jul 31, 2018
Member
srowen
left a comment
srowen
left a comment
There was a problem hiding this comment.
I'm OK with this. Conceptually the fields in this class don't have an ordering, but, given they do in the constructor, it's more sensible to consistently describe it as a (label, feature) pair. There are more instances of "(feature, label)" in the project; can you change all of them?
Member
|
Ping @uzmijnlm |
Member
|
@uzmijnlm I can take this over and add additional changes, if you're busy. Is that OK? |
Member
|
@srowen, +1 for taking over. Seems it's been inactive almost for a month. |
|
Test build #4287 has finished for PR 21665 at commit
|
Member
|
Actually, the other cases aren't referring to a LabeledPoint, so I'll leave them. This is fine, and I'll merge it. |
bogdanrdc
pushed a commit
to bogdanrdc/spark
that referenced
this pull request
Aug 28, 2018
## What changes were proposed in this pull request? An RDD is created using LabeledPoint, but the comment is like #LabeledPoint(feature, label). Although in the method ChiSquareTest.test, the second parameter is feature and the third parameter is label, it it better to write label in front of feature here because if an RDD is created using LabeldPoint, what we get are actually (label, feature) pairs. Now it is changed as LabeledPoint(label, feature). The comments in Scala and Java example have the same typos. ## How was this patch tested? tested https://issues.apache.org/jira/browse/SPARK-24688 Author: Weizhe Huang 492816239qq.com Please review http://spark.apache.org/contributing.html before opening a pull request. Closes apache#21665 from uzmijnlm/my_change. Authored-by: Huangweizhe <[email protected]> Signed-off-by: Sean Owen <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
An RDD is created using LabeledPoint, but the comment is like #LabeledPoint(feature, label).
Although in the method ChiSquareTest.test, the second parameter is feature and the third parameter is label, it it better to write label in front of feature here because if an RDD is created using LabeldPoint, what we get are actually (label, feature) pairs.
Now it is changed as LabeledPoint(label, feature).
The comments in Scala and Java example have the same typos.
How was this patch tested?
tested
https://issues.apache.org/jira/browse/SPARK-24688
Author: Weizhe Huang [email protected]
Please review http://spark.apache.org/contributing.html before opening a pull request.