[SPARK-23586][SQL] Add interpreted execution to WrapOption #20741
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hvanhovell
reviewed
Mar 5, 2018
| test("SPARK-23586: WrapOption should support interpreted execution") { | ||
| val cls = ObjectType(classOf[java.lang.Integer]) | ||
| val inputObject = BoundReference(0, cls, nullable = true) | ||
| val unwrapObject = WrapOption(inputObject, cls) |
hvanhovell
approved these changes
Mar 5, 2018
Contributor
hvanhovell
left a comment
hvanhovell
left a comment
There was a problem hiding this comment.
LGTM - pending Jenkins. Can you also touch up the name in the test case?
|
Test build #87976 has finished for PR 20741 at commit
|
Contributor
|
Merging to master. Thanks! |
|
Test build #87977 has finished for PR 20741 at commit
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
The PR adds interpreted execution to WrapOption.
How was this patch tested?
added UT