From 5995bd5447ed8d0d5ffcbfbf1132a1177892edd4 Mon Sep 17 00:00:00 2001
From: Dongjoon Hyun <dongjoon@apache.org>
Date: Sat, 19 Aug 2017 20:58:32 -0700
Subject: [PATCH] [SPARK-21791][SQL] ORC should support column names with dot

---
 .../apache/spark/sql/hive/orc/OrcSourceSuite.scala | 14 +++++++++++++-
 1 file changed, 13 insertions(+), 1 deletion(-)

diff --git a/sql/hive/src/test/scala/org/apache/spark/sql/hive/orc/OrcSourceSuite.scala b/sql/hive/src/test/scala/org/apache/spark/sql/hive/orc/OrcSourceSuite.scala
index 52fa401d32c1..6876345718c2 100644
--- a/sql/hive/src/test/scala/org/apache/spark/sql/hive/orc/OrcSourceSuite.scala
+++ b/sql/hive/src/test/scala/org/apache/spark/sql/hive/orc/OrcSourceSuite.scala
@@ -25,6 +25,7 @@ import org.apache.spark.sql.{QueryTest, Row}
 import org.apache.spark.sql.hive.HiveExternalCatalog
 import org.apache.spark.sql.hive.test.TestHiveSingleton
 import org.apache.spark.sql.sources._
+import org.apache.spark.sql.test.SQLTestUtils
 import org.apache.spark.sql.types._
 import org.apache.spark.util.Utils
 
@@ -196,7 +197,7 @@ abstract class OrcSuite extends QueryTest with TestHiveSingleton with BeforeAndA
   }
 }
 
-class OrcSourceSuite extends OrcSuite {
+class OrcSourceSuite extends OrcSuite with SQLTestUtils {
   override def beforeAll(): Unit = {
     super.beforeAll()
 
@@ -249,4 +250,15 @@ class OrcSourceSuite extends OrcSuite {
       )).get.toString
     }
   }
+
+  // This test works with Apache ORC 1.4.0
+  // https://github.com/apache/spark/pull/18953
+  ignore("SPARK-21791 ORC should support column names with dot") {
+    import spark.implicits._
+    withTempDir { dir =>
+      val path = new File(dir, "orc").getCanonicalPath
+      Seq(Some(1), None).toDF("col.dots").write.orc(path)
+      assert(spark.read.orc(path).collect().length == 2)
+    }
+  }
 }