Skip to content

[SPARK-20830][PYSPARK][SQL] Add posexplode and posexplode_outer #18049

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
zero323 wants to merge 3 commits into from
Closed

[SPARK-20830][PYSPARK][SQL] Add posexplode and posexplode_outer #18049

zero323 wants to merge 3 commits into from

Conversation

@zero323
Copy link
Member

@zero323 zero323 commented May 21, 2017

What changes were proposed in this pull request?

Add Python wrappers for o.a.s.sql.functions.explode_outer and o.a.s.sql.functions.posexplode_outer.

How was this patch tested?

Unit tests, doctests.

@SparkQA
Copy link

SparkQA commented May 21, 2017

Test build #77154 has finished for PR 18049 at commit 2fc576d.

  • This patch fails Python style tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@SparkQA
Copy link

SparkQA commented May 21, 2017

Test build #77155 has finished for PR 18049 at commit 44f2fea.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@gatorsmile
Copy link
Member

gatorsmile commented Jun 21, 2017

cc @ueshin

ueshin
ueshin reviewed Jun 21, 2017
View reviewed changes
Copy link
Member

@ueshin ueshin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, except for a comment.

python/pyspark/sql/tests.py Outdated
Copy link
Member

@ueshin ueshin Jun 21, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you extract the tests like ones for explode?

Copy link
Member Author

@zero323 zero323 Jun 21, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ueshin Of course, is this enough?

Copy link
Member

@ueshin ueshin Jun 21, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, looks good.

@SparkQA
Copy link

SparkQA commented Jun 21, 2017

Test build #78411 has finished for PR 18049 at commit 3e5c35d.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@ueshin
Copy link
Member

ueshin commented Jun 21, 2017

Thanks! merging to master.

@asfgit asfgit closed this in 215281d Jun 21, 2017
@zero323
Copy link
Member Author

zero323 commented Jun 21, 2017

Thanks @ueshin!

robert3005 pushed a commit to palantir/spark that referenced this pull request Jun 29, 2017
@zero323
[SPARK-20830][PYSPARK][SQL] Add posexplode and posexplode_outer
4a5749a 
## What changes were proposed in this pull request?

Add Python wrappers for `o.a.s.sql.functions.explode_outer` and `o.a.s.sql.functions.posexplode_outer`.

## How was this patch tested?

Unit tests, doctests.

Author: zero323 <[email protected]>

Closes apache#18049 from zero323/SPARK-20830.
@zero323 zero323 deleted the SPARK-20830 branch February 2, 2020 17:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ueshin ueshin ueshin left review comments

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@zero323 @SparkQA @gatorsmile @ueshin