[SPARK-20533][SparkR]:SparkR Wrappers Model should be private and value should be lazy #17808
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
felixcheung
approved these changes
Apr 29, 2017
Member
felixcheung
left a comment
felixcheung
left a comment
There was a problem hiding this comment.
ok, effect should be minor though, right?
|
Test build #76303 has finished for PR 17808 at commit
|
Member
|
merged to master - let me know if you think this should go to 2.2 as well |
Contributor
Author
|
I think we don't have to back-port. This is a small improvement/optimization of the original code. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
MultilayerPerceptronClassifierWrapper model should be private.
LogisticRegressionWrapper.scala rFeatures and rCoefficients should be lazy.
How was this patch tested?
Unit tests.