[SPARK-20126][SQL] Remove HiveSessionState #17457
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
Contributor
|
LGTM |
|
Test build #75311 has finished for PR 17457 at commit
|
Contributor
|
thanks, merging to master! |
gatorsmile
reviewed
Mar 28, 2017
| * | ||
| * Note: this method seems not access any session state, but the subclass `HiveSessionState` needs | ||
| * to add the jar to its hive client for the current session. Hence, it still needs to be in | ||
| * [[SessionState]]. |
Member
There was a problem hiding this comment.
This comment needs an update.
Member
|
A late LGTM. : ) |
Member
|
Maybe it is time to clean up |
gatorsmile
reviewed
Mar 28, 2017
| """.stripMargin) | ||
|
|
||
| val expectedPath = | ||
| sessionState.catalog.hiveDefaultTableFilePath(TableIdentifier("ctasJsonTable")) |
Member
There was a problem hiding this comment.
The function hiveDefaultTableFilePath can be removed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Commit ea36116 moved most of the logic from the SessionState classes into an accompanying builder. This makes the existence of the
HiveSessionStateredundant. This PR removes theHiveSessionState.How was this patch tested?
Existing tests.