Skip to content

[SPARK-20098][PYSPARK] dataType's typeName fix #17435

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 9 commits into from
Closed

[SPARK-20098][PYSPARK] dataType's typeName fix #17435

Show file tree
Hide file tree
Changes from 6 commits
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
00994e9
getType fix
szalai1 Mar 26, 2017
933f3cb
type
szalai1 Mar 26, 2017
0a18192
StructField's typeName raise TypeError
szalai1 May 13, 2017
6bf11f0
add test
szalai1 May 20, 2017
8872e19
fixing pep8 style issues
szalai1 Jun 25, 2017
a18436d
test failure fixed
szalai1 Sep 7, 2017
a451901
improving error message
szalai1 Sep 8, 2017
98bac12
adding space
szalai1 Sep 8, 2017
28f142c
space at thr right place
szalai1 Sep 9, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions python/pyspark/sql/tests.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -188,6 +188,10 @@ def test_empty_row(self):
row = Row()
self.assertEqual(len(row), 0)

def test_struct_field_type_name(self):
struct_field = StructField("a", IntegerType())
self.assertRaises(TypeError, struct_field.typeName)


class SQLTests(ReusedPySparkTestCase):

Expand Down
5 changes: 5 additions & 0 deletions python/pyspark/sql/types.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -438,6 +438,11 @@ def toInternal(self, obj):
def fromInternal(self, obj):
return self.dataType.fromInternal(obj)

def typeName(self):
raise TypeError(
Copy link
Member

@HyukjinKwon HyukjinKwon Sep 8, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could we do like ...

raise TypeError(
    "..."
    "...")

if it doesn't bother you much?

"StructField does not have typename. \
Copy link
Member

@HyukjinKwon HyukjinKwon Sep 8, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Little nit: looks a typo, typename -> typeName.

You can use self.dataType.simpleString() instead.")
Copy link
Member

@HyukjinKwon HyukjinKwon Sep 8, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd remove self here and just say something like use typeName() on its type explicitly ....

Copy link
Contributor Author

@szalai1 szalai1 Sep 8, 2017 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

you mean simpleString() and not typeName(). right ?

Copy link
Member

@HyukjinKwon HyukjinKwon Sep 8, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it should be typeName on its datatype because typeName was called.



class StructType(DataType):
"""Struct type, consisting of a list of :class:`StructField`.
Expand Down