-
Notifications
You must be signed in to change notification settings - Fork 29k
SPARK-1242 Add aggregate to python rdd #139
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
Closed
Changes from 2 commits
Commits
Show all changes
4 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -524,7 +524,7 @@ def _collect_iterator_through_file(self, iterator): | |
| def reduce(self, f): | ||
| """ | ||
| Reduces the elements of this RDD using the specified commutative and | ||
| associative binary operator. | ||
| associative binary operator. Currently reduces partitions locally. | ||
|
|
||
| >>> from operator import add | ||
| >>> sc.parallelize([1, 2, 3, 4, 5]).reduce(add) | ||
|
|
@@ -566,7 +566,32 @@ def func(iterator): | |
| vals = self.mapPartitions(func).collect() | ||
| return reduce(op, vals, zeroValue) | ||
|
|
||
| # TODO: aggregate | ||
| def aggregate(self, zeroValue, seqOp, combOp): | ||
| """ | ||
| Aggregate the elements of each partition, and then the results for all | ||
| the partitions, using a given combine functions and a neutral "zero | ||
| value." | ||
|
|
||
| The functions C{op(t1, t2)} is allowed to modify C{t1} and return it | ||
| as its result value to avoid object allocation; however, it should not | ||
| modify C{t2}. | ||
|
|
||
| The first function (seqOp) can return a different result type, U, than | ||
| the type of this RDD. Thus, we need one operation for merging a T into an U | ||
| and one operation for merging two U | ||
|
|
||
| >>> seqOp = (lambda x, y: (x[0] + y, x[1] + 1)) | ||
| >>> combOp = (lambda x, y: (x[0] + y[0], x[1] + y[1])) | ||
| >>> sc.parallelize([1, 2, 3, 4]).aggregate((0, 0), seqOp, combOp) | ||
| (10, 4) | ||
| """ | ||
| def func(iterator): | ||
| acc = zeroValue | ||
| for obj in iterator: | ||
| acc = seqOp(acc, obj) | ||
| if acc is not None: | ||
|
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. acc will never be None, right, because you set it to zeroValue? You can probably just |
||
| yield acc | ||
| return self.mapPartitions(func).reduce(combOp) | ||
|
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. nit: new line after |
||
|
|
||
| def sum(self): | ||
| """ | ||
|
|
||
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You should add a test where you
aggregatean empty RDD, because that finalreducewill fail in this case. You need to usefold(zeroValue, combOp)instead.