Skip to content

[SPARK-14937][ML][Document]spark.ml LogisticRegression sqlCtx in scala is inconsistent with java and python #12717

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 2 commits into from
Closed

[SPARK-14937][ML][Document]spark.ml LogisticRegression sqlCtx in scala is inconsistent with java and python #12717

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
dff3b2a
fix sqlCtx in example
wangmiao1981 Apr 26, 2016
a7e3cd5
fix linearregression and logisticregresstion trainning summary
wangmiao1981 Apr 26, 2016
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions ...s/src/main/scala/org/apache/spark/examples/ml/LinearRegressionWithElasticNetExample.scala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,11 +29,11 @@ object LinearRegressionWithElasticNetExample {
def main(args: Array[String]): Unit = {
val conf = new SparkConf().setAppName("LinearRegressionWithElasticNetExample")
val sc = new SparkContext(conf)
val sqlCtx = new SQLContext(sc)
val sqlContext = new SQLContext(sc)

// $example on$
// Load training data
val training = sqlCtx.read.format("libsvm")
val training = sqlContext.read.format("libsvm")
.load("data/mllib/sample_linear_regression_data.txt")

val lr = new LinearRegression()
Expand Down
6 changes: 3 additions & 3 deletions examples/src/main/scala/org/apache/spark/examples/ml/LogisticRegressionSummaryExample.scala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,11 +30,11 @@ object LogisticRegressionSummaryExample {
def main(args: Array[String]): Unit = {
val conf = new SparkConf().setAppName("LogisticRegressionSummaryExample")
val sc = new SparkContext(conf)
val sqlCtx = new SQLContext(sc)
import sqlCtx.implicits._
val sqlContext = new SQLContext(sc)
import sqlContext.implicits._
Copy link
Member

@srowen srowen Apr 27, 2016

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this import still needed? (I forget.) It's weird to use a variable name in the import isn't it? (I know it was already like that.) Otherwise this does look like all instances of sqlCtx in examples, yes.

Copy link
Contributor

@yanboliang yanboliang Apr 27, 2016

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's necessary, otherwise compiler will complains when use DataFrame methods.

Copy link
Member

@jkbradley jkbradley Apr 27, 2016

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think this import is needed anymore. It used to be there to use the toDF() method back when there was no libsvm data source.

Copy link
Contributor Author

@wangmiao1981 wangmiao1981 Apr 27, 2016

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let me try to fix it in this PR. Thanks!

Copy link
Contributor Author

@wangmiao1981 wangmiao1981 Apr 27, 2016

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jkbradley
69: val bestThreshold = fMeasure.where($"F-Measure" === maxFMeasure)
70: .select("threshold").head().getDouble(0)

Still needs the import. Otherwise, it won't be compiled.

Copy link
Member

@jkbradley jkbradley Apr 27, 2016

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh, OK, I guess it's the dollar sign notation


// Load training data
val training = sqlCtx.read.format("libsvm").load("data/mllib/sample_libsvm_data.txt")
val training = sqlContext.read.format("libsvm").load("data/mllib/sample_libsvm_data.txt")

val lr = new LogisticRegression()
.setMaxIter(10)
Expand Down
4 changes: 2 additions & 2 deletions ...src/main/scala/org/apache/spark/examples/ml/LogisticRegressionWithElasticNetExample.scala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,11 +29,11 @@ object LogisticRegressionWithElasticNetExample {
def main(args: Array[String]): Unit = {
val conf = new SparkConf().setAppName("LogisticRegressionWithElasticNetExample")
val sc = new SparkContext(conf)
val sqlCtx = new SQLContext(sc)
val sqlContext = new SQLContext(sc)

// $example on$
// Load training data
val training = sqlCtx.read.format("libsvm").load("data/mllib/sample_libsvm_data.txt")
val training = sqlContext.read.format("libsvm").load("data/mllib/sample_libsvm_data.txt")

val lr = new LogisticRegression()
.setMaxIter(10)
Expand Down